762697 - libstagefright video decoding renders frame with gray borders

Status: RESOLVED INCOMPLETE

(Core :: Audio/Video, defect)

Description

[cajbir (:cajbir)]

Some MP4 videos rendered with the libstagefright backend have grey borders around the video.

Steps to reproduce:

1) Visit http://cd.pn/b2
2) Play video

Results:

1) Video plays but with grey border on the bottom of the video

What should result:

1) Full frame shown with no gray border

The border does not appear when playing on android with the Android browser. I can't test in Fennec since it doesn't support MP4.

Comment 1

[cajbir (:cajbir)]

Attachment: Support crop rectangles in video payback

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 635164 [details] [diff] [review]
Support crop rectangles in video payback

Review of attachment 635164 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/omx-plugin/OmxPlugin.cpp
@@ +391,5 @@
> +    mVideoCropHeight = cropBottom - cropTop + 1;
> +  }
> +
> +  mVideoWidth = mVideoCropWidth;
> +  mVideoHeight = mVideoCropHeight;

Do we really need mVideoCrop{Width,Height} if we're doing this?

r+ on fix/clarification.

Comment 3

[Dietrich Ayala (:dietrich)]

What devices does this effect?
Does this still occur?

It only blocks basecamp if it occurs on Otoro devices running B2G. Please renominate if that's the case.

Comment 4

[Tony Chung [:tchung]]

bug 766395 is blocking this bug, as mp4 playback still does not work.

Comment 5

[cajbir (:cajbir)]

The code this patch affects has been completely rewritten in bug 759506. One that bug is complete we'll retest to see if the issue still exists. It currently affects all B2G devices that use hardware decoders, including Otoro.

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Edwin Flores [:eflores] [:edwin] from comment #2)
> Comment on attachment 635164 [details] [diff] [review]
> Support crop rectangles in video payback
> 
> 
> ::: media/omx-plugin/OmxPlugin.cpp
> @@ +391,5 @@
> > +    mVideoCropHeight = cropBottom - cropTop + 1;
> > +  }
> > +
> > +  mVideoWidth = mVideoCropWidth;
> > +  mVideoHeight = mVideoCropHeight;
> 
> Do we really need mVideoCrop{Width,Height} if we're doing this?
> 

Until gingerbread, "kKeyWidth" and "kKeyHeight" metadata say "video width" and "video height". But from ICS(Honycomb), meanings of some metadata were changed within stagefright like following without notice...

"kKeyWidth" -> decoded video buffer width
"kKeyHeight" -> decoded video buffer height
"kKeyCropRect" -> valid video rect area 

Until gingerbread, there were 2 interfaces to draw video. "push buffer surface" and "Overlay". After ICS(Honycomb), the interfaces are unified into one interface "ANativeWindow". I assume that it caused the metadata-change.

In ICS, stagefright calculate video width and height like following.
http://androidxref.com/4.0.4/xref/frameworks/base/media/libstagefright/AwesomePlayer.cpp#980

http://androidxref.com/4.0.4/xref/frameworks/base/media/libstagefright/colorconversion/SoftwareRenderer.cpp#33

Comment 7

[Chris Peterson [:cpeterson]]

doublec, do you have a device for investigating this bug?

kbrosnan lent me an HTC Desire HD running GB 2.3.5 that supposedly reproduced this issue, but I can't get the phone to play your http://cd.pn/b2 test video (even with the stagefright.force-enabled=true pref).

Comment 8

[cajbir (:cajbir)]

Any device that plays H.264 video should show it.

Comment 9

[cajbir (:cajbir)]

Does this still occur?

Comment 10

[cajbir (:cajbir)]

No reply to comment 9. Please open a new bug if it still occurs.