Closed Bug 762880 Opened 12 years ago Closed 12 years ago

Missing MOZALLOC_EXPORT causes link failure on mingw

Categories

(Core :: mozglue, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
It looks like bug 761859 accidentally removed MOZALLOC_EXPORT define, causing mozalloc_abort to not be marked as exported.

Successful try run:
https://tbpl.mozilla.org/?tree=Try&rev=e15ebf4408ca
Attachment #631366 - Flags: review?(ted.mielczarek)
Attachment #631366 - Attachment is patch: true
Comment on attachment 631366 [details] [diff] [review]
fix v1.0

Review of attachment 631366 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, sorry.
Attachment #631366 - Flags: review?(ted.mielczarek) → review+
Blocks: 761859
Target Milestone: --- → mozilla16
I accidentally referenced blocked bug instead of this one in the commit. Landed on m-c as:

https://hg.mozilla.org/mozilla-central/rev/93214bac07b2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: