763016 - Report telemetry data for if the MozillaMaintenance service is installed

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

We need to create a telemetry histogram for UPDATE_SERVICE_INSTALLED.  It should be a boolean histogram with values 0, 1 which correspond with whether or not the MozillaMaintenance service exists on the machine.

Comment 1

[Brian R. Bondy [:bbondy]]

This telemetry ping should only be sent from Windows machines.

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1 - Not yet tested

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2 -Tested

Comment 4

[Brian R. Bondy [:bbondy]]

After I wrote this patch I realized we have a registry entry for Installed with a DWORD value of 1 or 0.  But this patch may be more deterministic. But I'm open to changing it if you prefer to the reg way.

Comment 5

[Brian R. Bondy [:bbondy]]

Attachment: Patch v3

After thinking about it more, our other checks use the Installed reg value already so we might as well stay consistent.  Doing  a reg check is cleaner than using ctypes anyway.

The code is probably fine either way but in theory the SCM can be locked and it might take longer to check via the SCM.

Also this value will always be in sync with whether or not the service is actually installed unless a user goes and modifies it themselves.

Comment 6

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/mozilla-central/rev/1e497edb48c1