Closed
Bug 763242
Opened 12 years ago
Closed 12 years ago
Fix freetype detection on Non X11 linux builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla16
People
(Reporter: romaxa, Assigned: romaxa)
Details
Attachments
(1 file, 1 obsolete file)
5.75 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
On attempt to build on Linux without X11 (cairo-qt for example) I see message like: ERROR: Can't find header fontconfig/fcfreetype.h. I think we should move freetype detection part out of X11 test
Attachment #631711 -
Flags: review?(mh+mozilla)
Comment 1•12 years ago
|
||
Comment on attachment 631711 [details] [diff] [review] Check freetype under USE_FC_FREETYPE ifdef Review of attachment 631711 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +8858,5 @@ > > if test "$USE_FC_FREETYPE"; then > + dnl ======================================================== > + dnl = Check for freetype2 and its functionality > + dnl ======================================================== This needs to be under the COMPILE_ENVIRONMENT test.
Attachment #631711 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Got build error on try for original patch, due to undefinde CAIRO_FT_FLAGS.. So I moved whole check little bit above that test. try build for that looks good https://tbpl.mozilla.org/?tree=Try&rev=ca07bf26a527
Assignee: nobody → romaxa
Attachment #631711 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #631997 -
Flags: review?(mh+mozilla)
Updated•12 years ago
|
Attachment #631997 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0890dcf220c7
Keywords: checkin-needed
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0890dcf220c7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•