763396 - VKB is not dismissed when switching tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Nightly Fennec 16.0a1 (2012-06-10)
Device: HTC Desire Z 
OS: Android 2.3.3

Steps to Reproduce:
1. Open two or more pages in different tabs.
2. Open a new tab and load a page that contains a text input field and tap on it for the VKB to appear (ex: google.com)
3. Open the tab menu and switch to another tab.

Expected:
The VKB is dismissed.

Actual:
The VKB is not dismissed.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

> Step #3: "Open the tab menu and switch to another tab."

Shouldn't we have the fix in Tabs.selectTab(...) ?

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> > Step #3: "Open the tab menu and switch to another tab."
> 
> Shouldn't we have the fix in Tabs.selectTab(...) ?

That means the keyboard would still be visible when we click the tabs tray button and until the user actually selects a tab, which can potentially hide some of the tabs in the tabs tray. This patch should put us back the previous behavior before the regression from bug 739407, but we can also put this in selectTab() for tabs that are changed programmatically.

Comment 4

[Peter Retzer (:pretzer)]

IMO the VKB should be dismissed as soon as the tabs menu is invoked, for the reasons you already mentioned, Brian.

Comment 6

[Gabriela [:gaby2300]]

I can reproduce in Galaxy S2 using Android 2.3.4 and Nightly 20120618. 
I think it's worth to fix because the VKB should be dismissed as soon as the tabs menu is invoked, as stated above

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 631995 [details] [diff] [review]
patch


>     private void toggleTabs() {
>         if (GeckoApp.mAppContext.areTabsShown())
>             GeckoApp.mAppContext.hideTabs();
>-        else
>+        else {
>+            InputMethodManager imm =
>+                    (InputMethodManager) mContext.getSystemService(Context.INPUT_METHOD_SERVICE);
>+            imm.hideSoftInputFromWindow(mTabs.getWindowToken(), 0);
>             GeckoApp.mAppContext.showLocalTabs();
>+        }

the "if" block needs {} now too:

if () {
} else {
}

Also, we need a bug for closing the keyboard in selectTab

Comment 8

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e031f55fd997

Comment 9

[Brian Nicholson (:bnicholson)]

(In reply to Mark Finkle (:mfinkle) from comment #7)
> Also, we need a bug for closing the keyboard in selectTab

Filed bug 767147.

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e031f55fd997

Comment 11

[Cristian Nicolae (:xti)]

This issue is not longer reproducible on the latest Nightly build. Closing bug as verified fixed on:

Firefox 18.0a1 (2012-09-12)
Device: Galaxy Note
OS: Android 4.0.4