763437 - Do you want to send messages now [no] [yes] uses no and yes

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of dialog

Would be nice to hook up this dialog with proper verbs to enforce the actions.
What about: [Later] [Send Now]

(I also hate that dialog keeps blocking me and want it to be a notification bar, but that is bug #763436)

Comment 1

[:aceman]

Do you want to do this or is it free to take? :)

Comment 2

[Andreas Nilsson (:andreasn)]

Up for grabs!

Comment 3

[:aceman]

Thanks.
Does Seamonkey have this too?

Comment 4

[:aceman]

Attachment: patch

Double pack for Andreas, I did the other dialog (download msgs) too.

Comment 5

[Ian Neal]

(In reply to :aceman from comment #3)
> Thanks.
> Does Seamonkey have this too?

SeaMonkey has:
Would you like to send your unsent messages now?
with buttons "Send", "Don't Send" and "Cancel"

Comment 6

[:aceman]

Thanks, then you do not need this fix. Sometimes you are ahead :-P

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 632355 [details] [diff] [review]
patch

This is definitely better.  ui-r=me, based on that.

I think "Send now" then "Later" would be better still, since that follows the order in time of the two buttons.

And even better would be to just send the messages, and not interrupt the user.  ;)  (It looks like we could change the default value of "offline.send.unsent_messages" to achieve that…)

Thanks,
Blake.

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #7)
> And even better would be to just send the messages, and not interrupt the
> user.  ;)  (It looks like we could change the default value of
> "offline.send.unsent_messages" to achieve that…)
> 
> Thanks,
> Blake.

indeed, Bug 511079 would be better

Comment 9

[:aceman]

I don't think that one is related...

Comment 10

[:aceman]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #7)
> I think "Send now" then "Later" would be better still, since that follows
> the order in time of the two buttons.

I am not sure what you mean here. Should I change the order of the buttons? Or what?

Comment 11

[Blake Winton (:bwinton) (:☕️)]

Yes, switching the order of the buttons would make the dialog make more sense…

Comment 12

[:aceman]

I think the order also depends on platform, so you want the "Send now" be the first one (primary and default) and "Later" be the second. I think this will make Send on the left and Later on the right on Windows.

Comment 13

[:aceman]

But I think I have the buttons in that order. See BUTTON_POS_0 and BUTTON_POS_1 in the patch. I see "Send now" on the right on Linux (which often has buttons reversed). So what do you see?

Comment 14

[Blake Winton (:bwinton) (:☕️)]

I'll give you three guesses…  ;)

(I see "[Later] [Send now]" on the Mac.)

I think there are other kinds of dialogs that have a more consistent cross-platform button order…

Comment 15

[:aceman]

Kinds of dialogs? Culdn't find a better one in http://mxr.mozilla.org/comm-central/source/mozilla/embedding/components/windowwatcher/public/nsIPromptService.idl that also has the checkbox option. The confirmEx comments say the implementation (platform?) can decide the order. Why would we go against it. Also, the new order is the same as it was before, only labels have changed.

Comment 16

[Blake Winton (:bwinton) (:☕️)]

I also didn't see a better one.  :(

The confirmEx comments also say that if you're replacing all the buttons with custom strings, you might be doing something wrong.  Perhaps we should just leave them as they are.  :P

And finally, I'm not sure I can explain why "[Send now] [Later]" is better than "[Later] [Send now]" better than I did above…  If you agree that following the order in time is better, then surely it's better on all the platforms, no?

Comment 17

[:aceman]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #16)
> And finally, I'm not sure I can explain why "[Send now] [Later]" is better
> than "[Later] [Send now]" better than I did above…  If you agree that
> following the order in time is better, then surely it's better on all the
> platforms, no?

But I can't order it in the same way on all platforms (as some platforms reverse the order automatically). Maybe by ifdef'ing the code by platform. Do we want that?

Comment 18

[Magnus Melin [:mkmelin]]

I don't think it's actually so much a question of when it time you'll do it. It's really more of "send now" vs "i don't wanna deal with this/stupid dialog go away/irrelevant text". So i'd just go for the platform order for defaults.

Comment 19

[Blake Winton (:bwinton) (:☕️)]

Okay, fine, whatever.  I think it looks strange to have "Later" "Now", but if there's no way to actually put them in the right order, then let's just check this in and be done with it.

Comment 20

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 632355 [details] [diff] [review]
patch

Review of attachment 632355 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. Thanks aceman!

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/1457e1545968