763856 - Need way to leave a JSAutoEnterCompartment without waiting for the destructor to be called

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bobby Holley (:bholley)]

This has been annoying me. In general, it's great to use scoping. But sometimes, it unnecessarily complicates the code. For example, sometimes we want to leave the compartment before doing a tail function call. Currently, we have to unnecessarily brace/indent a lot of things to make this happen.

Patch coming up.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Introduce JSAutoEnterCompartment::leave(). v1

Attaching a patch, flagging luke for review.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 1 - Clarify compartment semantics for ExposedPropertiesOnly. v1

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 2 - Clarify compartment situation in Xray wrapper. v1

Adding to the mess of the NodePrincipal (et al) check isn't great, but I'm refactoring that in bug 761704.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 1 - Clarify compartment semantics for ExposedPropertiesOnly. v2

Added an updated comment to clarify why two JSAutoEnterCompartments are necessary.

Comment 5

[Bobby Holley (:bholley)]

Gah! Wrong bug number for those other patches. Sorry blake. :-(

Comment 6

[Bobby Holley (:bholley)]

One thing I realized about this patch is that it allows the consumer to pooch the compartment situation by leaving compartments out of order. I suspect it's not worth worrying about, but maybe we should add some asserts somehow?

Comment 7

[Bobby Holley (:bholley)]

Pushed to m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f195d6de172f

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/f195d6de172f