764127 - some return values in Windows runtime stub are wrong type or wrongly interpreted

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: corrects return values

While reviewing the fix for bug 760747, I noticed that in the Windows webapp runtime stub AttemptGRELoadAndLaunch() sometimes returns an nsresult (i.e. an int), although its return type is boolean.  And main() assigns the return value of GetFirefoxDirFromRegistry() to `rv`, which is an nsresult, although the return value of that function is a boolean.

Here are the obvious fixes.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 632380 [details] [diff] [review]
patch v1: corrects return values

https://hg.mozilla.org/integration/mozilla-inbound/rev/deaaaefbc089

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/deaaaefbc089

Comment 3

[Jason Smith [:jsmith]]

Sounds like this is internal code changes - no verification needed (correct me if I'm incorrect though Myk if you think there is end-user testing to this).