Closed
Bug 764237
Opened 12 years ago
Closed 12 years ago
Compile of XULRunner fails - 'strcasecmp': identifier not found, 'snprintf': identifier not found
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox14- fixed, firefox15 fixed)
RESOLVED
FIXED
mozilla16
People
(Reporter: nthomas, Assigned: glandium)
References
Details
Attachments
(1 file)
983 bytes,
patch
|
benjamin
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
From http://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/14.0b7-candidates/build1/logs/release-mozilla-beta-xulrunner_win32_build-bm13-build1-build6.txt.gz which is building FIREFOX_14_0b7_RELEASE out of the mozilla-beta repo: make -C xulrunner libs make[5]: Entering directory `/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/obj-firefox/xulrunner' make[6]: Entering directory `/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/obj-firefox/xulrunner/app' nsXULRunnerApp.cpp d:/mozilla-build/python25/python2.5.exe -O e:/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/build/cl.py cl -FonsXULRunnerApp.obj -c -DAB_CD=en-US -DXULRUNNER_PROGNAME=\"xulrunner\" -DTARGET_XPCOM_ABI=\"x86-msvc\" -DXPCOM_GLUE -DMOZ_WINCONSOLE=0 -DOSTYPE=\"WINNT5.2\" -DOSARCH=WINNT -DXULRUNNER_ICO=\"../../dist/branding/xulrunner.ico\" -DDOCUMENT_ICO=\"../../dist/branding/document.ico\" -I/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/toolkit/xre -I/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/toolkit/profile -I/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/xpcom/base -I/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/xpcom/build -I/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/xulrunner/app -I. -I../../dist/include -I../../dist/include/nsprpub -Ie:/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/obj-firefox/dist/include/nspr -Ie:/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/obj-firefox/dist/include/nss -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4800 -we4553 -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O1 -Oy -MD -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT /e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/xulrunner/app/nsXULRunnerApp.cpp nsXULRunnerApp.cpp e:/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/xulrunner/app/nsXULRunnerApp.cpp(112) : error C3861: 'strcasecmp': identifier not found e:/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/xulrunner/app/nsXULRunnerApp.cpp(117) : error C3861: 'strcasecmp': identifier not found e:/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/xulrunner/app/nsXULRunnerApp.cpp(401) : error C3861: 'snprintf': identifier not found make[6]: Leaving directory `/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/obj-firefox/xulrunner/app' make[5]: Leaving directory `/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/obj-firefox/xulrunner' make[4]: Leaving directory `/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/obj-firefox' make[3]: Leaving directory `/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/obj-firefox' make[2]: Leaving directory `/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build/obj-firefox' make[1]: Leaving directory `/e/builds/moz2_slave/rel-m-beta-xr-w32-bld/build' make[6]: *** [nsXULRunnerApp.obj] Error 2 make[5]: *** [app_libs] Error 2 make[4]: *** [libs_tier_app] Error 2 make[3]: *** [tier_app] Error 2 make[2]: *** [default] Error 2 make[1]: *** [realbuild] Error 2 make: *** [build] Error 2 We didn't have this problem on FIREFOX_14_0b6_RELEASE (which happened to use the same slave).
Reporter | ||
Comment 1•12 years ago
|
||
Bug 756786 is the only change in xulrunner/ between b6 and b7. Requesting tracking-firefox14 since this impacts on people who use the XULRunner SDK to create addons.
Blocks: 756786
tracking-firefox14:
--- → ?
Assignee | ||
Comment 2•12 years ago
|
||
That's an overlook from bug 764237. These are defined in nsBrowserApp.cpp. Removing duplicate #includes at the same time.
Attachment #632544 -
Flags: review?(benjamin)
Updated•12 years ago
|
Attachment #632544 -
Flags: review?(benjamin) → review+
Reporter | ||
Comment 3•12 years ago
|
||
Looks like this needs to go on central, aurora and beta, based on the contents of the dirs like http://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/latest-mozilla-aurora/ and comments in bug 756786.
Assignee: nobody → mh+mozilla
Reporter | ||
Updated•12 years ago
|
Summary: Compile of XULRunner 14.0b7 failed - 'strcasecmp': identifier not found, 'snprintf': identifier not found → Compile of XULRunner fails - 'strcasecmp': identifier not found, 'snprintf': identifier not found
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3f408698a03f
Status: NEW → RESOLVED
Closed: 12 years ago
status-firefox14:
--- → affected
status-firefox15:
--- → affected
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 632544 [details] [diff] [review] Add snprintf and strcasecmp definitions in nsXULRunnerApp.cpp for windows [Approval Request Comment] Bug caused by bug 756786 User impact if declined: xulrunner is not built on windows since bug 756786 landing. Testing completed (on m-c, etc.): latest xulrunner nightly built successfully on all platforms Risk to taking this patch (and alternatives if risky): Only applies to xulrunner, and only to windows code, so the worst case scenario would be failing to fix xulrunner. String or UUID changes made by this patch: none
Attachment #632544 -
Flags: approval-mozilla-beta?
Attachment #632544 -
Flags: approval-mozilla-aurora?
Comment 6•12 years ago
|
||
Comment on attachment 632544 [details] [diff] [review] Add snprintf and strcasecmp definitions in nsXULRunnerApp.cpp for windows [Triage Comment] Approving as this will only affect xulrunner builds if there are any followup issues.
Attachment #632544 -
Flags: approval-mozilla-beta?
Attachment #632544 -
Flags: approval-mozilla-beta+
Attachment #632544 -
Flags: approval-mozilla-aurora?
Attachment #632544 -
Flags: approval-mozilla-aurora+
Updated•12 years ago
|
Comment 7•12 years ago
|
||
Did this get landed for aurora and beta?
Assignee | ||
Comment 8•12 years ago
|
||
Not yet, I'm going to.
Assignee | ||
Comment 9•12 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/9db11ac5983d http://hg.mozilla.org/releases/mozilla-beta/rev/6f116c26fdad
Comment 10•12 years ago
|
||
Thanks glandium.
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•