764285 - Use virtual keycodes in SDK for Mac instead of defined by ourselves

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Use virtual keycodes defined in SDK

It doesn't make sense to redefine keycode by our naming rules.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Use naming rules of virtual keycodes in SDK for defining undefined keycode

Use same naming rules when we define undefined keycodes.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 632591 [details] [diff] [review]
part.1 Use virtual keycodes defined in SDK

Where do symbols like "kVK_F16" live?  I can't find them anywhere in the tree.

What is the "SDK"?  It seems to be a separate download.  Which means that these patches will make it an additional build prerequisite.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

> Where do symbols like "kVK_F16" live?  I can't find them anywhere in the tree.

Never mind.  I just found them in the Events.h header file of Apple's HIToolbox framework.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 632591 [details] [diff] [review]
part.1 Use virtual keycodes defined in SDK

This looks fine to me.

I notice that you've dropped the "tilde" keycode (0x32).  But that's just because Events.h calls it by a different name (kVK_ANSI_Grave).

I did a build (on OS X 10.7.4) of both this bug's patches, and it finished with no problems.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 632592 [details] [diff] [review]
part.2 Use naming rules of virtual keycodes in SDK for defining undefined keycode

Looks fine to me.

I did a build (on OS X 10.7.4) of both this bug's patches, and it finished with no problems.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f516031218f
https://hg.mozilla.org/integration/mozilla-inbound/rev/83f49d543833

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/83f49d543833
https://hg.mozilla.org/mozilla-central/rev/0f516031218f