Closed Bug 764579 Opened 12 years ago Closed 12 years ago

PromptService.Show should be PromptService.show

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox15 fixed, firefox16 fixed)

RESOLVED FIXED
Firefox 16
Tracking Status
firefox15 --- fixed
firefox16 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Java naming convention consistency.
Attachment #632879 - Flags: review?(margaret.leibovic)
Comment on attachment 632879 [details] [diff] [review]
Patch

Review of attachment 632879 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/PromptService.java
@@ +381,5 @@
>          boolean multiple = false;
>          try {
>              multiple = geckoObject.getBoolean("multiple");
>          } catch(Exception ex) { }
> +        this.show(title, text, promptbuttons, menuitems, multiple);

As per Java conventions, we can get rid of the |this.| here.
Attachment #632879 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/bf12b1b12b2d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: