Closed
Bug 764746
Opened 12 years ago
Closed 12 years ago
[devtb] style the error counter
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: paul, Assigned: paul)
References
Details
Attachments
(3 files, 5 obsolete files)
920.79 KB,
image/png
|
Details | |
41.42 KB,
image/png
|
Details | |
5.21 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → paul
Assignee | ||
Comment 1•12 years ago
|
||
Basic approach: we replace the icon with the counter.
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #636292 -
Attachment is obsolete: true
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #636293 -
Flags: review?(dao)
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 636293 [details] [diff] [review] v1.1 (wrong patch, sorry)
Attachment #636293 -
Flags: review?(dao)
Assignee | ||
Comment 6•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #636293 -
Attachment is obsolete: true
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 636719 [details] [diff] [review] v1.2 Can you please review the devtools code?
Attachment #636719 -
Flags: review?(mihai.sucan)
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 636719 [details] [diff] [review] v1.2 I need a browser review too!
Attachment #636719 -
Flags: review?(dao)
Assignee | ||
Comment 9•12 years ago
|
||
For some reasons, I forgot to add "-moz-box-pack:center" to the pseudo element. I will add that after the reviews.
Comment 10•12 years ago
|
||
Comment on attachment 636719 [details] [diff] [review] v1.2 Patch looks fine and UI is awesome. I like the toolbar changes. It looks much better. The :( smiley doesn't show. I get: Error: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIStringBundle.GetStringFromName] Source File: resource:///modules/devtools/DeveloperToolbar.jsm Line: 500 Giving the patch r+ but please fix this.
Attachment #636719 -
Flags: review?(mihai.sucan) → review+
Assignee | ||
Comment 11•12 years ago
|
||
mssing entry in jar.mn
Assignee | ||
Updated•12 years ago
|
Attachment #636719 -
Attachment is obsolete: true
Attachment #636719 -
Flags: review?(dao)
Assignee | ||
Updated•12 years ago
|
Attachment #636897 -
Flags: review?(dao)
Comment 12•12 years ago
|
||
Comment on attachment 636897 [details] [diff] [review] v1.3 >+# The error counter is located in front of the Web Console button in the developer >+# toolbar. This counter can only hold 2 characters. Why can it only hold 2 characters?
Assignee | ||
Comment 13•12 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #12) > Comment on attachment 636897 [details] [diff] [review] > v1.3 > > >+# The error counter is located in front of the Web Console button in the developer > >+# toolbar. This counter can only hold 2 characters. > > Why can it only hold 2 characters? Technically, it can. But I don't want the counter to grow and move all the buttons when it reaches 100. I want the counter to look like it replaces the icon.
Comment 14•12 years ago
|
||
":(" is a nice gimmick, but not very informative or self-explanatory. Between this and the counter growing slightly when reaching 100, I think the latter is preferable. "99+" would be ok too, but of course this has the same problem that you tried to avoid.
Assignee | ||
Comment 15•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #636897 -
Attachment is obsolete: true
Attachment #636897 -
Flags: review?(dao)
Assignee | ||
Updated•12 years ago
|
Attachment #637107 -
Flags: review?(dao)
Assignee | ||
Comment 16•12 years ago
|
||
review ping
Comment 17•12 years ago
|
||
Comment on attachment 637107 [details] [diff] [review] v1.4 >+#developer-toolbar-webconsole[error-count]:before { >+ content: attr(error-count); >+ display: -moz-box; >+ -moz-box-pack: center; This part should probably be in a content stylesheet.
Attachment #637107 -
Flags: review?(dao) → review+
Assignee | ||
Comment 18•12 years ago
|
||
thank you Dao.
Assignee | ||
Updated•12 years ago
|
Attachment #637107 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 19•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7c1d395ebab7
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 20•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7c1d395ebab7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•