Closed Bug 764989 Opened 12 years ago Closed 12 years ago

Add about: page event listeners only to pages that need them

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 790934

People

(Reporter: fryn, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We're currently adding the about: page event listeners to every about: page, including about:newtab and possibly about:blank. We should only add them to pages that need them.

We also add them twice for each document and each iframe inside those documents.
I have a patch that fixes the iframe piece.
Fixing the twice-per-document piece is more difficult. Marco and I were investigating that in bug 749477.
Attachment #633254 - Flags: review?(gavin.sharp)
Attachment #633254 - Flags: review?(gavin.sharp)
BrowserOnClick got refactored, which made the code easier to maintain and understand, but this bug still exists.

It doesn't seem to be a priority to address this, so unassigning self.
Status: ASSIGNED → NEW
Assignee: fryn → nobody
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: