Closed
Bug 765239
Opened 12 years ago
Closed 12 years ago
Typo in importScript would fail to use importedScripts
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: automatedtester, Assigned: automatedtester)
Details
Attachments
(1 file, 1 obsolete file)
3.84 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
Minor typo and probably isnt being used yet file = FileUtils.openFileOutputStream(importedScripts, FielUtils.MODE_APPEND);
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #633533 -
Flags: review?(mdas)
Comment 2•12 years ago
|
||
Comment on attachment 633533 [details] [diff] [review] fix for the typo Review of attachment 633533 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! We should add a test case for this code path before landing it
Attachment #633533 -
Flags: review?(mdas) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #633533 -
Attachment is obsolete: true
Attachment #633997 -
Flags: review?(mdas)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dburns
Comment 4•12 years ago
|
||
Comment on attachment 633997 [details] [diff] [review] Fix for appending to file and a test case to prove Review of attachment 633997 [details] [diff] [review]: ----------------------------------------------------------------- Looks really good, thanks for the patch!
Attachment #633997 -
Flags: review?(mdas) → review+
Assignee | ||
Comment 5•12 years ago
|
||
landed in https://hg.mozilla.org/mozilla-central/rev/373e6f9264e6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•