765302 - add noScriptRval option to evaluate()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Bug 755808 was awesome, let's do another one of those.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 633581 [details] [diff] [review]
v1

Review of attachment 633581 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ +832,5 @@
> +        if (!JSVAL_IS_VOID(v)) {
> +            JSBool b;
> +            if (!JS_ValueToBoolean(cx, v, &b))
> +                return false;
> +            noScriptRval = !!b;

We turned off whatever lame MSVC warning used to warn about this so you can leave off the ever-so-attractive !! if you'd like.

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/892392714fc2