765341 - Make js_ValueToAtom's signature more normal (return JSAtom* rather than bool+redundant JSAtom** outparam)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

This is practically trivial rs=-land, but for an API change I feel like I should record a bug for it, probably.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 633629 [details] [diff] [review]
Patch

Review of attachment 633629 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on the change, r- on the bug title. This creates js::ToAtom, which follows the pattern of js::ToObject and js::ToString, but differs from js::ToNumber, js::ToUint32, js::ToInteger, js::ToPrimitive, and every JSAPI function that takes an initial JSContext* and returns a bool. I don't know how many calls we have that take a leading JSContext*, return non-bool, and might set a pending exception.

(That said, I'm fine with the change.)

Comment 2

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/94dd2b2a8216