765418 - Logging into dashboard with no apps previously installed on a machine shows nothing even with apps installed until a forced refresh

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Jason Smith [:jsmith]]

Prerequiste: A persona account with apps already installed to the account.

Steps:

1. Start Firefox with a fresh profile with the configs set to enable AITC and the dashboard
2. Go to myapps and login with the prerequiste account

Expected:

The dashboard should show the apps installed for that account.

Actual:

Nothing shows up. On refresh of the dashboard, the apps appear on the dashboard.

Comment 1

[Jason Smith [:jsmith]]

Should generalize this - it happens even when there are apps installed to the dashboard already, in which those apps completely disappear. This wasn't happening before.

Comment 2

[Anant Narayanan [:anant]]

Removing local apps that were installed before but aren't on the server will be deleted. That's expected behaviour. The correct solution for this will be applied in bug 761045.

As for having to refresh the dashboard, sounds like it's an issue with the mozApps addListener or the dashboard itself. It's unlikely that AITC would be causing this.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Anant Narayanan [:anant] from comment #2)
> Removing local apps that were installed before but aren't on the server will
> be deleted. That's expected behaviour. The correct solution for this will be
> applied in bug 761045.

I know. But I'm talking about here in the case where the apps with an account other than the account currently logged in (so all app data in this case was tied to the server).

> 
> As for having to refresh the dashboard, sounds like it's an issue with the
> mozApps addListener or the dashboard itself. It's unlikely that AITC would
> be causing this.

It seems unlikely this is a dashboard bug, given that the code for that hasn't changed in a long time, and we know this was working before. It's probably more likely a problem in the mozapps API in this case.

Flagging for regression window analysis - I'll figure out the changeset breaking this...

Comment 4

[Anant Narayanan [:anant]]

(In reply to Jason Smith [:jsmith] from comment #3)
> (In reply to Anant Narayanan [:anant] from comment #2)
> > Removing local apps that were installed before but aren't on the server will
> > be deleted. That's expected behaviour. The correct solution for this will be
> > applied in bug 761045.
> 
> I know. But I'm talking about here in the case where the apps with an
> account other than the account currently logged in (so all app data in this
> case was tied to the server).

Let's chat about this in-person, I'm still not sure what you mean.

> > As for having to refresh the dashboard, sounds like it's an issue with the
> > mozApps addListener or the dashboard itself. It's unlikely that AITC would
> > be causing this.
> 
> It seems unlikely this is a dashboard bug, given that the code for that
> hasn't changed in a long time, and we know this was working before. It's
> probably more likely a problem in the mozapps API in this case.
> 
> Flagging for regression window analysis - I'll figure out the changeset
> breaking this...

I'd start with bug 754141:

https://hg.mozilla.org/mozilla-central/rev/dda070f5ce28
https://hg.mozilla.org/mozilla-central/rev/f6cd8c9e5f44
https://hg.mozilla.org/mozilla-central/rev/4fd8a9d9aef8
https://hg.mozilla.org/mozilla-central/rev/bb8b085db9ee

Comment 5

[Jason Smith [:jsmith]]

(In reply to Anant Narayanan [:anant] from comment #4)
> (In reply to Jason Smith [:jsmith] from comment #3)
> > (In reply to Anant Narayanan [:anant] from comment #2)
> > > Removing local apps that were installed before but aren't on the server will
> > > be deleted. That's expected behaviour. The correct solution for this will be
> > > applied in bug 761045.
> > 
> > I know. But I'm talking about here in the case where the apps with an
> > account other than the account currently logged in (so all app data in this
> > case was tied to the server).
> 
> Let's chat about this in-person, I'm still not sure what you mean.

Yeah, let's talk about in person at this point.

> 
> > > As for having to refresh the dashboard, sounds like it's an issue with the
> > > mozApps addListener or the dashboard itself. It's unlikely that AITC would
> > > be causing this.
> > 
> > It seems unlikely this is a dashboard bug, given that the code for that
> > hasn't changed in a long time, and we know this was working before. It's
> > probably more likely a problem in the mozapps API in this case.
> > 
> > Flagging for regression window analysis - I'll figure out the changeset
> > breaking this...
> 
> I'd start with bug 754141:
> 
> https://hg.mozilla.org/mozilla-central/rev/dda070f5ce28
> https://hg.mozilla.org/mozilla-central/rev/f6cd8c9e5f44
> https://hg.mozilla.org/mozilla-central/rev/4fd8a9d9aef8
> https://hg.mozilla.org/mozilla-central/rev/bb8b085db9ee

And weirdly enough, now I'm not getting a reproduction of what's in the bug on two machines (windows). I'll have to check my Mac machine that this reproduced on to see this issue again.

Comment 6

[Jason Smith [:jsmith]]

No longer reproduces. Closing.