765889 - a role="navigation" attribute is missing on the nav element

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect)

Description

[Isac Lagerblad (:icaaq)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0a1
Build ID: 20120618030531

Steps to reproduce:

1. Press Cmd+N to open a new browser window, then type https://marketplace.mozilla.org/en-US/ in the address bar and press Enter
2. Inspect #site-header > section > nav


Actual results:

The nav element is missing a role="navigation" attribute.


Expected results:

As Steve Faulkner says[http://www.paciellogroup.com/blog/2012/06/html5-accessibility-chops-when-to-use-an-aria-role/]:

It will be years before New HTML5 elements get robust accessibility support implemented across browsers and platforms. This is particularly so for non interactive elements such as the new HTML5 structural elements because  accessibility APIs in general do not have defined roles for many non interactive elements. In this case it is recommended to add the appropriate ARIA roles to elements that are meant to convey meaning but are effectively meaningless due to lack of implemented accessibility support.
For example, adding role=navigation to a nav element fills the gaps in support for HTML5 semantics as ARIA  is more robustly  supported by most modern browsers and assistive technology:

<nav role=”navigation”>

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/94faf83

Comment 2

[krupa raj[:krupa]]

verified fixed.

Comment 3

[krupa raj[:krupa]]

Attachment: post-fix screenshot