7659 - Alert dialogs crash when I hit ok.

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

using davidm's new nsINetSupportDialogService, an alert dialog will crash when I
hit OK.

I've got the fix and I'm going to check it in.

Comment 1

[(not reading, please use [e-mail] instead)]

fixed.  the problem was in nsNetSupportDialog.cpp

here's the diff that I checked in:
Index: nsNetSupportDialog.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/appshell/src/nsNetSupportDialog.cpp,v
retrieving revision 1.8
diff -r1.8 nsNetSupportDialog.cpp
407c407,408
<       *mReturnValue = kOKButton;
---
>   if ( mReturnValue )
>     *mReturnValue = kOKButton;

Comment 2

[davidm]

*** Bug 7662 has been marked as a duplicate of this bug. ***

Comment 3

[phillip]

code level fix, marking verified.

Comment 4

[james]

This is happening for me again on Netscape6/PR3 (Linux x86) will attach sample
HTML to cause crash

Comment 5

[james]

Attachment: test case for crash on NS6/PR3 (Linux x86)

Comment 6

[(not reading, please use [e-mail] instead)]

yes, I see the crash in PR3.

it looks like it is fixed for RTM, since I don't get the crash anymore.

marking fixed.