Closed Bug 765919 Opened 12 years ago Closed 6 years ago

Fix compilation on cygwin

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: alexmac, Unassigned)

Details

Attachments

(1 file)

Attached patch cygwin.patchSplinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.56 Safari/536.5

Steps to reproduce:

Cygwin has lots of quirks that prevent compilation, this patch fixes those compilation errors mostly by providing stubs that abort at runtime, but I have yet to see them hit in practice.
Attachment #634184 - Attachment is patch: true
Comment on attachment 634184 [details] [diff] [review]
cygwin.patch

Looks fine. A bit inconsistent as to whether comments are inside or outside the ifdef blocks. For what it's worth, I think inside is usually better since the association between the comment and the code is less likely to be damaged by subsequent edits.
Attachment #634184 - Flags: review+
Attachment #634184 - Flags: review+ → review?(stan)
Attachment #634184 - Flags: review?(stan) → review+
Tamarin is a dead project now. Mass WONTFIX.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: