765989 - Add fail on warnings to some gfx directories

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[Benoit Girard (:BenWa)]

Comment on attachment 634255 [details] [diff] [review]
Patch

Nice! I'm happy to take these patch as long as they don't warn anywhere.

Comment 2

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Fix warnings on gcc

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 634670 [details] [diff] [review]
Patch

Review of attachment 634670 [details] [diff] [review]:
-----------------------------------------------------------------

http://www.opengl.org/sdk/docs/man/xhtml/glTexImage2D.xml

internalformat should be GLint. Feel free to land the other warning fixes.

Comment 4

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0ee88e6ac05

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/c0ee88e6ac05

Comment 6

[(no longer active)]

Hrm, why was the r-'ed patch landed?!

Comment 7

[Benoit Girard (:BenWa)]

(In reply to Ehsan Akhgari [:ehsan] from comment #6)
> Hrm, why was the r-'ed patch landed?!

It was not. There was one change to make and we discussed it over IRC.

David can you reattach the revised copy on the bug and mention you got r+ from me over IRC for transparency?

Comment 8

[David Zbarsky (:dzbarsky)]

Attachment: Landed patch, r=benwa over irc