766000 - CompositionNotifySink needs a virtual destructor

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[(no longer active)]

PluginStreamParent.cpp
In file included from /Users/ehsanakhgari/moz/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp:7:
In file included from /Users/ehsanakhgari/moz/mozilla-central/dom/plugins/ipc/PluginInstanceParent.h:10:
In file included from ../../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstanceParent.h:9:
In file included from ../../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstance.h:14:
In file included from ../../../dist/include/IPC/IPCMessageUtils.h:23:
In file included from ../../../dist/include/gfxPattern.h:14:
../../../dist/include/nsAutoPtr.h:71:11: warning: delete called on 'mozilla::layers::CompositionNotifySink' that is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor]
          delete mRawPtr;
          ^
/Users/ehsanakhgari/moz/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp:55:23: note: in instantiation of member function
      'nsAutoPtr<mozilla::layers::CompositionNotifySink>::~nsAutoPtr' requested here
PluginInstanceParent::PluginInstanceParent(PluginModuleParent* parent,
                      ^

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 634261 [details] [diff] [review]
Patch (v1)

r++++ would review again

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc5fee7d85c4

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cc5fee7d85c4