766120 - Stop conflating effects offset and continuation union size in nsSVGIntegrationUtils

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

More disentanglement from bug 614732, this time to remove the conflation of the concepts of effects offset and continuation union size in nsSVGIntegrationUtils. I found it terribly confusing trying to understand what on earth was going on when SVG terms such as "user space" and "bbox" were being perverted to mean things that they're not. This doesn't completely fix those issues, but it's a decent first pass.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Sorry, that was the wrong patch.

Comment 3

[Robert Longson [:longsonr]]

nsSVGIntegrationUtils::GetSVGCoordContextForNonSVGFrame might be better called nsSVGIntegrationUtils::GetSVGCoordSizeForNonSVGFrame

r=longsonr either way

Comment 4

[Jonathan Watt [:jwatt]]

Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/d7caec31923e

(In reply to Robert Longson from comment #3)
> nsSVGIntegrationUtils::GetSVGCoordContextForNonSVGFrame might be better
> called nsSVGIntegrationUtils::GetSVGCoordSizeForNonSVGFrame

It's more the size of the context than of a coord, at least to my mind, so I left it as it is. Plus I'm really trying to avoid conflicting queue at the moment.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d7caec31923e