766273 - B2G telephony on Otoro: Can't hang up dialing call

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

STR:

1. Dial a number.
2. Hang up while it's still ringing (don't wait for the other side to pick up.)
3. Dialed phone keeps ringing.

Seems like the Otoro RIL isn't too happy about using REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND for dialing calls:

I/Gecko   (  115): RIL Worker: Solicited response for request type 14, token 87, error 2
I/Gecko   (  115): RIL Worker: Handling parcel as REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND

Comment 1

[Philipp von Weitershausen [:philikon]]

Hsinyi, would you mind taking a look at this?

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Philipp von Weitershausen [:philikon] from comment #1)
> Hsinyi, would you mind taking a look at this?
Sure! Just got a new phone and will take care of this.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: patch

Philipp, you're right. Too bad that Otoro doesn't like REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND. The patch fixes this.

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 634836 [details] [diff] [review]
patch

Looks good. Thanks!

Unrelated to this Otoro-specific issue: It occurred to me that we don't have tests for some of these scenarios, e.g. hanging up a dialing call. Would you mind writing some? (Can do it in a follow-up.)

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Philipp von Weitershausen [:philikon] from comment #4)
> Comment on attachment 634836 [details] [diff] [review]
> patch
> 
> Looks good. Thanks!
> 
> Unrelated to this Otoro-specific issue: It occurred to me that we don't have
> tests for some of these scenarios, e.g. hanging up a dialing call. Would you
> mind writing some? (Can do it in a follow-up.)
I filed bug 766822 for these test cases. Let's move there for related discussion.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Try server result https://tbpl.mozilla.org/?tree=Try&rev=d498ea306a23

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/96eb15859e36

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/96eb15859e36

Comment 9

[Jason Smith [:jsmith]]

John - Can you verify this fix when an otoro build is available?

Comment 10

[Maria Angeles Oteo (:oteo)]

A new bug has been reported after applying this patch in Otoro
https://bugzilla.mozilla.org/show_bug.cgi?id=768878