766756 - Show compatibility error if an add-on invokes queryCommandText or execCommandShowHelp

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 742261, queryCommandText and execCommandShowHelp have been removed from nsIDOMHTMLDocument. We need to flag all instances of these methods and show an error.

This is a compatibility error, so the add-on should not be upgraded in this case.

Message:

The queryCommandText and execCommandShowHelp functions have been removed from the nsIDOMHTMLDocument interface. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=742261

Affected add-on:

https://addons.mozilla.org/en-US/firefox/addon/firebug/

Comment 1

[Matt Basta [:basta]]

Pull request:

https://github.com/mozilla/amo-validator/pull/161

Comment 2

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/amo-validator/commit/86d06cfabca5ede6ca0d5da072a5851bffde65be

Comment 3

[krupa raj[:krupa]]

> Affected add-on:
> 
> https://addons.mozilla.org/en-US/firefox/addon/firebug/

Jorge, basta tells me that firebug doesn't use these flagged methods in a way which would fail compatibility.

Are you aware of any other add-ons which do? mxr wasn't very helpful.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

I only found Firebug-related add-ons that do this. If that code doesn't cause any compat problems, there's nothing else that needs testing.