Closed
Bug 766988
Opened 12 years ago
Closed 12 years ago
Disabling screenshot code still allows incremental screenshot updates
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox16 fixed)
RESOLVED
FIXED
Firefox 16
Tracking | Status | |
---|---|---|
firefox16 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file, 1 obsolete file)
1.85 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
Currently if you change sDisableScreenshot to true and start Fennec, you get the following exception: 06-21 15:15:34.866 W/System.err( 4982): java.lang.NullPointerException 06-21 15:15:34.866 W/System.err( 4982): at org.mozilla.gecko.ScreenshotHandler$RepaintRunnable.addRectToRepaint(GeckoAppShell.java:2263) 06-21 15:15:34.866 W/System.err( 4982): at org.mozilla.gecko.ScreenshotHandler.notifyPaintedRect(GeckoAppShell.java:2276) 06-21 15:15:34.866 W/System.err( 4982): at org.mozilla.gecko.GeckoAppShell.notifyPaintedRect(GeckoAppShell.java:2192) 06-21 15:15:34.866 W/System.err( 4982): at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method) 06-21 15:15:34.866 W/System.err( 4982): at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method) 06-21 15:15:34.866 W/System.err( 4982): at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method) 06-21 15:15:34.874 W/System.err( 4982): at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:476) 06-21 15:15:34.874 W/System.err( 4982): at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:90) because sCheckerboardPageRect is set to null, but the paint listener is still running and tries to queue up dirty rects. This codepath should also check for sDisableScreenshot.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #635323 -
Flags: review?(blassey.bugs)
Assignee | ||
Comment 2•12 years ago
|
||
Updated patch to also take care of bug 766498 since it's pretty much the same code.
Attachment #635323 -
Attachment is obsolete: true
Attachment #635323 -
Flags: review?(blassey.bugs)
Attachment #635328 -
Flags: review?(blassey.bugs)
Updated•12 years ago
|
Attachment #635328 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c2bab7807b3
status-firefox16:
--- → fixed
Target Milestone: --- → Firefox 16
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7c2bab7807b3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•