Closed
Bug 76719
Opened 23 years ago
Closed 23 years ago
SaveAs->file|Template menu items don't work on standalone win
Categories
(MailNews Core :: Composition, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: sheelar, Assigned: ssu0262)
Details
(Whiteboard: [nsbeta1+]Have Fix)
Attachments
(2 files)
1.58 KB,
patch
|
Details | Diff | Splinter Review | |
923 bytes,
patch
|
Details | Diff | Splinter Review |
Buildid: 2001-04-19-08 linux and mac steps to reproduce: Double click an existing message to open to a stand alone window Go to Menu item File|Save As Expected: Both file|template should be enabled and should let you save as file or template Actual: Both file|template menu items are disabled and does not let the user save as file or template an existing message from the stand alone window. But these menu items are enabled from the 3 pane. Disable only from standalone window.
Reporter | ||
Comment 1•23 years ago
|
||
change qa contact, add keywords. Could be a regression. I was able to save as file or template from a standalone window in previous builds.
Keywords: nsbeta1
QA Contact: esther → sheelar
Reporter | ||
Comment 2•23 years ago
|
||
More information... When you double click a message from inbox, sent, or any user created folders both pop and imap is when the above menu items are disabled. But these menu item are available in a standalone window for messages opened from drafts,templates folders both imap and pop.
Comment 3•23 years ago
|
||
Drafts and templates shouldn't open up a standalone window. This isn't happening to me on Windows. Is this still happening on Linux and Mac for you? Are there other menuitems that aren't working?
Reporter | ||
Comment 4•23 years ago
|
||
Messages opened from drafts and templates folder are in edit mode and can be saved. Problem is with other folders like inbox,or user defined folder. In 4.x when you double click on an existing message from inbox it opens in a stand alone window and you can save as file/template. In today's build the menu items are enabled but perform no action. Should this be a new bug?
Comment 5•23 years ago
|
||
sorry, I was looking for them to be disabled. But you are right that they don't work but do work in 3 pane. reassigning to ssu for nsbeta1+
Assignee: ducarroz → ssu
Priority: -- → P2
Summary: SaveAs->file|Template menu items disabled on standalone win → SaveAs->file|Template menu items don't work on standalone win
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.1
I have a fix for this. However, the SaveAs|File and SaveAs|Template menu items will be disabled until the body of the message is clicked. This is bug 76745. When these menu items are enabled, my patch will work.
Status: NEW → ASSIGNED
Comment 8•23 years ago
|
||
cc'ing varada who should be the reviewer.
Updated•23 years ago
|
Whiteboard: [nsbeta1+] → [nsbeta1+]Have Fix
Comment 10•23 years ago
|
||
no go on that patch. there's a better (cleaner) way to fix this. reimplement MsgSaveAsTemplate() and MsgSaveAsFile() to use GetNumSelectedMessages() and GetFirstSelectedMessage(). those are defined to do the right thing in messageWindow.js and msgMail3PaneWindow.js something like: function MsgSaveAsTemplate() { var folder = GetLoadedMsgFolder(); if (GetNumSelectedMessages() == 1) { SaveAsTemplate(GetFirstSelectedMessage(), folder); } }
Assignee | ||
Comment 11•23 years ago
|
||
Comment 12•23 years ago
|
||
reviewed and tested the new patch. r=varada
Comment 13•23 years ago
|
||
sr=sspitzer we might have similar bugs with similar fixes lurking in mailWindowOverlay.js (or other files). if you have the cycles, you could see what looks fishy or scan bugzilla for some stand alone msg window only problems.
Assignee | ||
Comment 14•23 years ago
|
||
will do Seth. Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 15•23 years ago
|
||
verified: win98-2001050706 linux-2001050708 mac-2001050209
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•