767377 - The filtering textbox expands when entering a string

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Ioana (away)]

Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120621 Firefox/15.0a2 (20120621042006)

STR:
1. Load http://htmlpad.org/debugger/ in the browser.
2. Open the Debugger (Tools->Web developer->Debugger, or press Ctrl+Shift+S).
3. Select the jquery.min.js script in the dropdown.
4. Enter a "j" in the filtering textbox.

The textbox expands automatically. It's a small expansion but it's very visible to me.

Comment 1

[Ioana (away)]

Attachment: Dropdown content with no filters

Comment 2

[Ioana (away)]

Attachment: Filter textbox expanding

Comment 3

[Victor Porof [:vporof][:vp]]

Can't reproduce this on OS X, but I think we can get away with this if we set a specific width in the CSS.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 5

[Dão Gottwald [:dao]]

Why does this patch affect all platforms? This bug is likely due to <http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/winstripe/global/textbox-aero.css#l7> and therefore Windows-specific.

Comment 6

[Victor Porof [:vporof][:vp]]

(In reply to Dão Gottwald [:dao] from comment #5)
> Why does this patch affect all platforms? This bug is likely due to
> <http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/
> winstripe/global/textbox-aero.css#l7> and therefore Windows-specific.

If we're going to add a width, we might as well do it on all platforms.
Is there something inherently wrong with doing so? I have no objections on fixing this only on Windows, but it would be nice to have the same sizes apply on all OS.

Comment 7

[Dão Gottwald [:dao]]

<http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/winstripe/global/textbox-aero.css#l7> affecting the textbox width is basically a toolkit bug that would ideally be fixed at a lower level rather than on a per-textbox basis. So unless the width is useful for other reasons, I think it makes sense to think of this as an interim solution that can be limited to Windows.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Dão Gottwald [:dao] from comment #7)
> <http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/
> winstripe/global/textbox-aero.css#l7> affecting the textbox width is
> basically a toolkit bug that would ideally be fixed at a lower level rather
> than on a per-textbox basis. So unless the width is useful for other
> reasons, I think it makes sense to think of this as an interim solution that
> can be limited to Windows.

In that same line of thought it may be best to add an aero-only debugger stylesheet with this workaround. On the other hand this may be going too far.

I'm personally fine either way.

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #8)
> (In reply to Dão Gottwald [:dao] from comment #7)
> > <http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/
> > winstripe/global/textbox-aero.css#l7> affecting the textbox width is
> > basically a toolkit bug that would ideally be fixed at a lower level rather
> > than on a per-textbox basis. So unless the width is useful for other
> > reasons, I think it makes sense to think of this as an interim solution that
> > can be limited to Windows.
> 
> In that same line of thought it may be best to add an aero-only debugger
> stylesheet with this workaround. On the other hand this may be going too far.
> 
> I'm personally fine either way.

Let's just add the width in the debugger win css as a temporary fix.
Or we could just not do anything and let the toolkit people to fix it? Who should we ping?

Comment 10

[Victor Porof [:vporof][:vp]]

Attachment: v2

Alright then.

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 642345 [details] [diff] [review]
v2

Review of attachment 642345 [details] [diff] [review]:
-----------------------------------------------------------------

A comment that points to the bug and/or textbox-aero.css would help us remember when to get rid of it.

Comment 12

[Victor Porof [:vporof][:vp]]

Attachment: v2.1

Commented.

Comment 13

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/492fb99ae0d8

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/492fb99ae0d8