Closed
Bug 767733
Opened 12 years ago
Closed 12 years ago
MediaManager must push JS context before calling callbacks.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
firefox13 | --- | unaffected |
firefox14 | --- | unaffected |
People
(Reporter: jst, Assigned: jst)
Details
(Keywords: regression)
Attachments
(1 file)
1.84 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #636107 -
Flags: review?(bugs)
Assignee | ||
Comment 1•12 years ago
|
||
Guessing sg:moderate.
status-firefox-esr10:
--- → unaffected
status-firefox13:
--- → unaffected
status-firefox14:
--- → unaffected
status-firefox15:
--- → affected
status-firefox16:
--- → affected
tracking-firefox15:
--- → +
tracking-firefox16:
--- → +
Whiteboard: [sg:moderate]
Updated•12 years ago
|
Attachment #636107 -
Flags: review?(bugs) → review+
Comment 2•12 years ago
|
||
Comment on attachment 636107 [details] [diff] [review] Use nsCxPusher before making calls to callbacks. Actually, if these runnables are used only via event loop, XPConnect's push/pop should be enough. But if the runnables are used as scriptrunners, we must have the cxpusher stuff.
Assignee | ||
Comment 3•12 years ago
|
||
These runnables should run straight from the event loop, as they're posted from the a different thread to the main thread. So if we don't need them in that case, I'm fine with marking this invalid.
Updated•12 years ago
|
Keywords: sec-moderate
Whiteboard: [sg:moderate]
Updated•12 years ago
|
Keywords: regression
Comment 4•12 years ago
|
||
This bug has kind of stalled out. Is this still valid?
Comment 5•12 years ago
|
||
Shouldn't be valid. (though, I'm not familiar with MediaManager)
Comment 6•12 years ago
|
||
Based on my understanding, XPConnect takes care of setting up the correct JS context when passing values from chrome to content. MediaManager uses standard XPConnect techniques to pass a MediaStream to the provided callback, so I think we can safely close this bug.
Comment 7•12 years ago
|
||
(In reply to Anant Narayanan [:anant] from comment #6) > Based on my understanding, XPConnect takes care of setting up the correct JS > context when passing values from chrome to content. Nothing to do with this bug > MediaManager uses > standard XPConnect techniques to pass a MediaStream to the provided > callback, so I think we can safely close this bug. By default when calling a callback one should push JS context to stack, but if it is know the callback is always async, we can rely on XPConnect to push null to the JS context stack.
Comment 8•12 years ago
|
||
Should we untrack or is there any remaining action here for FF16?
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
Updated•12 years ago
|
Group: core-security
status-firefox-esr10:
unaffected → ---
status-firefox15:
affected → ---
status-firefox16:
affected → ---
tracking-firefox15:
+ → ---
tracking-firefox16:
+ → ---
Keywords: sec-moderate
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•