767791 - java.lang.IndexOutOfBoundsException: getChars (0 ... <n>) ends beyond length 0 at android.text.SpannableStringBuilder.checkRange(SpannableStringBuilder.java) at org.mozilla.gecko.GeckoInputConnection.getExtractedText

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Keyboards and IME, defect, P2)

Description

[Scoobidiver (away)]

This bug was filed from the Socorro interface and is 
report bp-883d1a79-4730-4c4b-a9a7-6b4e02120624 .
============================================================= 

java.lang.IndexOutOfBoundsException: getChars (0 ... 9309) ends beyond length 0
	at android.text.SpannableStringBuilder.checkRange(SpannableStringBuilder.java:945)
	at android.text.SpannableStringBuilder.getChars(SpannableStringBuilder.java:839)
	at android.text.SpannableStringBuilder.toString(SpannableStringBuilder.java:862)
	at org.mozilla.gecko.GeckoInputConnection.getExtractedText(GeckoInputConnection.java:230)
	at com.android.internal.view.IInputConnectionWrapper.executeMessage(IInputConnectionWrapper.java:266)
	at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage(IInputConnectionWrapper.java:77)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4424)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=FennecAndroid%3A16.0a1&query_search=signature&query_type=contains&query=android.text.SpannableStringBuilder.checkRange&do_query=1

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: part-1-empty-Editable-exception.patch

Part 1: Do not call Editable.toString() if Editable has no text.

This is an Android bug. Editable.toString() may randomly crash because SpannableStringBuilder.getChars() does not account for its mGapLength when checking its [start, end) copy range. This seems to happen most often when length is 0 and the end index is very large.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: part-2-fix-range-brackets.patch

Part 2: Selection ranges exclude end index, so write [a,b), not (a,b].

This patch just fixes some typos in comments and log messages.

Comment 3

[Chris Peterson [:cpeterson]]

* part 1 may not be necessary after bug 769520 lands.
* part 2 landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/301d38e920a0

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/301d38e920a0

Comment 5

[Chris Peterson [:cpeterson]]

I believe my fix for bug 769520 will fix these IndexOutOfBoundsExceptions, but I will watch Socorro topcrashes for a few days before resolving this bug.

Comment 6

[Chris Peterson [:cpeterson]]

The fix for bug 769520, which landed in build Nightly 16 (2012-07-10), should have fixed these IndexOutOfBoundsExceptions. I'm resolving this bug as FIXED because I do not see any IndexOutOfBoundsExceptions in Socorro for builds >= Nightly 16 (2012-07-10).

Comment 7

[Scoobidiver (away)]

It happens after the backout of bug 769520: bp-e1d3866d-b87f-49c4-9797-ec85f2120906.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.