Closed
Bug 767835
Opened 12 years ago
Closed 12 years ago
new tabs show about:privatebrowsing with "Never remember history"
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 16
People
(Reporter: c.ascheberg, Assigned: ehsan.akhgari)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
2.77 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
1. Set history settings to "Never remember history" 2. Open new tab Result: about:privatebrowsing is shown Expected: show about:blank for example, as changing the history mode permanently is not really the same as private browsing Also, custom settings for the browser.newtab.url pref are not respected, as suggested in bug 762938 comment #13
Comment 1•12 years ago
|
||
(In reply to Christian Ascheberg from comment #0) > Also, custom settings for the browser.newtab.url pref are not respected, as > suggested in bug 762938 comment #13 Thank you for pointing this out. We totally overlooked it. I filed bug 767836 for this specific issue.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → ehsan
status-firefox16:
--- → affected
tracking-firefox16:
--- → +
Keywords: regression
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #636362 -
Flags: review?(ttaubert)
Assignee | ||
Comment 3•12 years ago
|
||
(I'd include a test, but unfortunately it's not possible to test the autoStarted mode in browser-chrome, since we read the value of the respective pref on profile-after-change.
Comment 4•12 years ago
|
||
Comment on attachment 636362 [details] [diff] [review] Patch (v1) Review of attachment 636362 [details] [diff] [review]: ----------------------------------------------------------------- Is showing about:newtab as the new tab page the right choice for this scenario?
Assignee | ||
Comment 5•12 years ago
|
||
I think so, yes.
Comment 6•12 years ago
|
||
I was just wondering what's the typical use case for this feature. If that's a specific profile always auto-run in PB mode, then showing about:newtab would be rather useless because there's nothing to show and we're not allowing additions to it, right? It's only useful if the user has gathered a "normal" history before he turned on this feature. Please correct me if I'm wrong.
Assignee | ||
Comment 7•12 years ago
|
||
We have no way of knowing that. The user may turn on that pref at any time, although the possibility of somebody installing Firefox for the first time and immediately toggling that pref is not great. We can also default to about:blank in this case. It's not immediately obvious if that would be an improvement though.
Comment 8•12 years ago
|
||
Comment on attachment 636362 [details] [diff] [review] Patch (v1) Review of attachment 636362 [details] [diff] [review]: ----------------------------------------------------------------- Right, hard to tell... I think it's better than showing about:privatebrowsing, though. So r=me and we'll see how it goes.
Attachment #636362 -
Flags: review?(ttaubert) → review+
Reporter | ||
Comment 9•12 years ago
|
||
about:newtab does not seem to display bookmarks (if there is no history). Is that correct? Could that be changed to fill empty cells?
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 10•12 years ago
|
||
Right, there's no data if you never had any history in your profile. Not sure what we should fill the empty cells with...
Reporter | ||
Comment 11•12 years ago
|
||
What I tried to say is: include actual bookmarks, there might be some of them as they are persistent. It currently does not seem to do that.
Assignee | ||
Comment 12•12 years ago
|
||
(In reply to Christian Ascheberg from comment #11) > What I tried to say is: include actual bookmarks, there might be some of > them as they are persistent. It currently does not seem to do that. Please file another bug for that.
Assignee | ||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e195dd3a989
Target Milestone: --- → Firefox 16
Comment 14•12 years ago
|
||
Backed out for mochitest-browser-chrome failures: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4e195dd3a989 eg: https://tbpl.mozilla.org/php/getParsedLog.php?id=12991945&tree=Mozilla-Inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/0c149cc0dd0c
Target Milestone: Firefox 16 → ---
Comment 15•12 years ago
|
||
Looks like this is called even before gPrivateBrowsingUI has been initialized. That also means we'll have to update the value of BROWSER_NEW_TAB_URL after it has been initialized.
Assignee | ||
Comment 16•12 years ago
|
||
Attachment #636362 -
Attachment is obsolete: true
Attachment #636978 -
Flags: review?(ttaubert)
Comment 17•12 years ago
|
||
Comment on attachment 636978 [details] [diff] [review] Patch (v2) Review of attachment 636978 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! r=me assuming try is green. ::: browser/base/content/browser.js @@ +6936,5 @@ > + get initialized() { > + return this._inited; > + }, > + > + addInitializationCallback: function PBUI_addInitializationCallback(callback) { Nit: aCallback.
Attachment #636978 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 18•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ca8d61d7993
Target Milestone: --- → Firefox 16
Comment 19•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0ca8d61d7993
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 20•12 years ago
|
||
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20100101 Firefox/16.0 Verified across platforms: Mac OS 10.7, Windows 7, Ubuntu 12.04. If a user has set a custom page for new tab, it will be displayed both in PB mode and with Clear Recent History option. With about:newtab, about:privatebrowsing isdisplayed in PB mode.
You need to log in
before you can comment on or make changes to this bug.
Description
•