768050 - Make TypedArray::Create take a wrapper cache and create JS objects in the compartment of the cache's wrapper

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 636352 [details] [diff] [review]
v1

r=me

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 636352 [details] [diff] [review]
v1

Review of attachment 636352 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/TypedArray.h
@@ +48,5 @@
> +         T* data = NULL) {
> +    JSObject* creatorWrapper;
> +    JSAutoEnterCompartment ac;
> +    if (creator && (creatorWrapper = creator->GetWrapperPreserveColor())) {
> +      ac.enter(cx, creatorWrapper);

Need to check for failure.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Mmm.  Can it fail in a non-insane way?  There's not much we can do about failure in a constructor....

Comment 4

[Peter Van der Beken [:peterv]]

I made it return NULL if enter fails (due to OOM).

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee34f7b36241

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ee34f7b36241