768138 - EncNoDeclaration string contains a grammatical error

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Jeff Walden [:Waldo]]

"The character encoding of the page must to be declared in the document or in the transfer protocol."

s/must to be/must be/

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Zap the bogus "to"

It's unclear to me if the string should get a new id in this case. Should it?

Comment 2

[Henri Sivonen (:hsivonen)]

Comment on attachment 641838 [details] [diff] [review]
Zap the bogus "to"

Whoa. The earlier review request went nowhere. Trying again.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 641838 [details] [diff] [review]
Zap the bogus "to"

Review of attachment 641838 [details] [diff] [review]:
-----------------------------------------------------------------

This is just a grammar fix, that doesn't need a key change. When the en-US string is really just wrong grammar, and doesn't change meaning, it's fine to just change the value.

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: Zap the bogus "to", v2

Comment 5

[Henri Sivonen (:hsivonen)]

Thanks for the r+.
https://hg.mozilla.org/integration/mozilla-inbound/rev/85872a2e11db

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/85872a2e11db