Closed Bug 768441 Opened 12 years ago Closed 10 years ago

B2G SMS: Support Stored Message Waiting Indicators

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g18 fixed)

RESOLVED FIXED
1.3 C1/1.4 S1(20dec)
Tracking Status
b2g18 --- fixed

People

(Reporter: marshall, Assigned: bevis)

References

Details

Attachments

(2 files, 1 obsolete file)

We don't currently persist SMS indicators marked as STORE (either through PID or DCS). TS 23.040 9.2.3.24.2 mentions that these indicators should be (optionally) stored in the EFmwis if it is available.

Once an indicator is stored, it should probably also be read on RIL daemon startup and fired as a SmsManager.onindicator DOM event
Support for this would be available in commercial RIL in AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.098.
Assignee: nobody → anshulj
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to Anshul from comment #1)
> Support for this would be available in commercial RIL in
> AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.098.

We're talking about Mozilla RIL.  Please DO NOT close a bug because that's implemented in commercial RIL.
Assignee: anshulj → nobody
Status: RESOLVED → REOPENED
Component: DOM: Device Interfaces → RIL
Product: Core → Boot2Gecko
Resolution: FIXED → ---
Version: Trunk → unspecified
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #2)
> (In reply to Anshul from comment #1)
> > Support for this would be available in commercial RIL in
> > AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.098.
> 
> We're talking about Mozilla RIL.  Please DO NOT close a bug because that's
> implemented in commercial RIL.
Sorry Vicamo, didn't realize it was opened by a Mozilla engineer.
Assignee: nobody → btseng
This patch is to support to store the MWI status into EF_MWIS in (U)SIM.
Possible MWI messages are level 2 MWI (DCS) and level 3 (Special SMS Indicators).
Level 1 MWI is not included due to the reason in bug#946079 to treat the return call message as a replacement type of message instead.

Corresponding test case is coming in next attachment.
Attachment #8346397 - Flags: review?(vyang)
Add test case to verify the read/write of EF_MWIS.
Attachment #8346399 - Flags: review?(vyang)
Comment on attachment 8346397 [details] [diff] [review]
Patch_Part_1: Support Stored Message Waiting Indicators

Review of attachment 8346397 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +4206,5 @@
>  
>        this.sendChromeMessage(message);
>  
> +      // Update MWI Status into ICC if present.
> +      if (message.mwi && (this.appType === CARD_APPTYPE_SIM || this.appType === CARD_APPTYPE_USIM)) {

ICCUtilsHelper.isICCServiceAvailable("MWIS")
Attachment #8346397 - Flags: review?(vyang) → review+
Attachment #8346399 - Flags: review?(vyang) → review+
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #6)
> Comment on attachment 8346397 [details] [diff] [review]
> Patch_Part_1: Support Stored Message Waiting Indicators
> 
> Review of attachment 8346397 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/ril_worker.js
> @@ +4206,5 @@
> >  
> >        this.sendChromeMessage(message);
> >  
> > +      // Update MWI Status into ICC if present.
> > +      if (message.mwi && (this.appType === CARD_APPTYPE_SIM || this.appType === CARD_APPTYPE_USIM)) {
> 
> ICCUtilsHelper.isICCServiceAvailable("MWIS")

Thanks for better suggestion. :)
Attachment #8346399 - Attachment description: Patch_Part_1: Test Case to Verify the Access of EF_MWIS → Patch_Part_2_v1: Test Case to Verify the Access of EF_MWIS
Use ICCUtilsHelper.isICCServiceAvailable("MWIS") to check the availbility of MWI when updating it.
Attachment #8346397 - Attachment is obsolete: true
Attachment #8346399 - Attachment description: Patch_Part_2_v1: Test Case to Verify the Access of EF_MWIS → Patch_Part_2_v1: Test Case to Verify the Access of EF_MWIS. r=vyang.
Attachment #8347074 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9b08b5ca2909
https://hg.mozilla.org/mozilla-central/rev/2ea15bd93a1b
Status: REOPENED → RESOLVED
Closed: 11 years ago10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Blocks: 1017821
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: