Closed
Bug 768441
Opened 12 years ago
Closed 10 years ago
B2G SMS: Support Stored Message Waiting Indicators
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(b2g18 fixed)
RESOLVED
FIXED
1.3 C1/1.4 S1(20dec)
Tracking | Status | |
---|---|---|
b2g18 | --- | fixed |
People
(Reporter: marshall, Assigned: bevis)
References
Details
Attachments
(2 files, 1 obsolete file)
6.51 KB,
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
8.64 KB,
patch
|
bevis
:
review+
|
Details | Diff | Splinter Review |
We don't currently persist SMS indicators marked as STORE (either through PID or DCS). TS 23.040 9.2.3.24.2 mentions that these indicators should be (optionally) stored in the EFmwis if it is available. Once an indicator is stored, it should probably also be read on RIL daemon startup and fired as a SmsManager.onindicator DOM event
Support for this would be available in commercial RIL in AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.098.
Assignee: nobody → anshulj
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g18:
--- → fixed
Resolution: --- → FIXED
Comment 2•11 years ago
|
||
(In reply to Anshul from comment #1) > Support for this would be available in commercial RIL in > AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.098. We're talking about Mozilla RIL. Please DO NOT close a bug because that's implemented in commercial RIL.
Assignee: anshulj → nobody
Status: RESOLVED → REOPENED
Component: DOM: Device Interfaces → RIL
Product: Core → Boot2Gecko
Resolution: FIXED → ---
Version: Trunk → unspecified
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #2) > (In reply to Anshul from comment #1) > > Support for this would be available in commercial RIL in > > AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.098. > > We're talking about Mozilla RIL. Please DO NOT close a bug because that's > implemented in commercial RIL. Sorry Vicamo, didn't realize it was opened by a Mozilla engineer.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → btseng
Assignee | ||
Comment 4•10 years ago
|
||
This patch is to support to store the MWI status into EF_MWIS in (U)SIM. Possible MWI messages are level 2 MWI (DCS) and level 3 (Special SMS Indicators). Level 1 MWI is not included due to the reason in bug#946079 to treat the return call message as a replacement type of message instead. Corresponding test case is coming in next attachment.
Attachment #8346397 -
Flags: review?(vyang)
Assignee | ||
Comment 5•10 years ago
|
||
Add test case to verify the read/write of EF_MWIS.
Attachment #8346399 -
Flags: review?(vyang)
Comment 6•10 years ago
|
||
Comment on attachment 8346397 [details] [diff] [review] Patch_Part_1: Support Stored Message Waiting Indicators Review of attachment 8346397 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_worker.js @@ +4206,5 @@ > > this.sendChromeMessage(message); > > + // Update MWI Status into ICC if present. > + if (message.mwi && (this.appType === CARD_APPTYPE_SIM || this.appType === CARD_APPTYPE_USIM)) { ICCUtilsHelper.isICCServiceAvailable("MWIS")
Attachment #8346397 -
Flags: review?(vyang) → review+
Updated•10 years ago
|
Attachment #8346399 -
Flags: review?(vyang) → review+
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #6) > Comment on attachment 8346397 [details] [diff] [review] > Patch_Part_1: Support Stored Message Waiting Indicators > > Review of attachment 8346397 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/system/gonk/ril_worker.js > @@ +4206,5 @@ > > > > this.sendChromeMessage(message); > > > > + // Update MWI Status into ICC if present. > > + if (message.mwi && (this.appType === CARD_APPTYPE_SIM || this.appType === CARD_APPTYPE_USIM)) { > > ICCUtilsHelper.isICCServiceAvailable("MWIS") Thanks for better suggestion. :)
Assignee | ||
Updated•10 years ago
|
Attachment #8346399 -
Attachment description: Patch_Part_1: Test Case to Verify the Access of EF_MWIS → Patch_Part_2_v1: Test Case to Verify the Access of EF_MWIS
Assignee | ||
Comment 8•10 years ago
|
||
Use ICCUtilsHelper.isICCServiceAvailable("MWIS") to check the availbility of MWI when updating it.
Attachment #8346397 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8346399 -
Attachment description: Patch_Part_2_v1: Test Case to Verify the Access of EF_MWIS → Patch_Part_2_v1: Test Case to Verify the Access of EF_MWIS. r=vyang.
Assignee | ||
Updated•10 years ago
|
Attachment #8347074 -
Flags: review+
Assignee | ||
Comment 9•10 years ago
|
||
update try server test result: https://tbpl.mozilla.org/?tree=Try&rev=ba6f8c6985cb
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/9b08b5ca2909 https://hg.mozilla.org/integration/b2g-inbound/rev/2ea15bd93a1b
Flags: in-testsuite+
Keywords: checkin-needed
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9b08b5ca2909 https://hg.mozilla.org/mozilla-central/rev/2ea15bd93a1b
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•