768626 - Add missing PropertyId rooting methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

These are needed for the rooting analysis and for exact stack rooting.

Comment 1

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57127eda3007

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/57127eda3007

Comment 3

[Steve Fink [:sfink] [:s:]]

gcc disagrees:

js/src/jsgc.cpp: In function ‘void js::MarkExactStackRoots(JSTracer*)’:
js/src/jsgc.cpp:883:100: error: cannot convert ‘jsid’ to ‘jsid*’ for argument ‘2’ to ‘void js::gc::MarkIdRoot(JSTracer*, jsid*, const char*)’

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Followup to fix PropertyId exact root marking

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 638422 [details] [diff] [review]
Followup to fix PropertyId exact root marking

Review of attachment 638422 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the bustage.  I put the equivalent to this patch in my tree last night, but didn't have internet today to upload it.

Comment 6

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1e6e5607105d

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1e6e5607105d