768723 - Split up BasicLayers.cpp into a few files

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nick Cameron [:nrc]]

It's just too big and it makes my head hurt

Comment 1

[Nick Cameron [:nrc]]

https://tbpl.mozilla.org/?tree=Try&rev=4be379a4e391

Comment 2

[Nick Cameron [:nrc]]

Attachment: split up basiclayers.cpp

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 637000 [details] [diff] [review]
split up basiclayers.cpp

Review of attachment 637000 [details] [diff] [review]:
-----------------------------------------------------------------

I think if you use hg copy to copy BasicLayers.cpp to all the new files, then delete the code each file doesn't need, we can still have usable history for each file and a cleaner diff to review here.

Comment 4

[Nick Cameron [:nrc]]

Attachment: split up basiclayers.cpp

Comment 5

[Nick Cameron [:nrc]]

try push: https://tbpl.mozilla.org/?tree=Try&rev=0aa7230a9f66

Comment 6

[Nick Cameron [:nrc]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=3c5f8eb756bf

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c5f8eb756bf

Comment 8

[Jesse Ruderman]

Usable history: great.

Making diffstat think you removed 40000 lines of code: awesome.

hg log --stat -r 3c5f8eb756bf