Closed
Bug 769077
Opened 12 years ago
Closed 12 years ago
Uninitialized render buffers do not report memory usage correctly
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
VERIFIED
FIXED
mozilla16
People
(Reporter: jon, Assigned: jon)
Details
Attachments
(2 files)
|
217 bytes,
text/html
|
Details | |
|
2.15 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
I found this while running the WebGL Conformance Tests in a debug build of trunk. If you visit the attached webpage and then visit about:memory, Firefox will always NS_ABORT() when getting the memory usage of unintialized render buffers. This is because it doesn't handle the case where mInternalFormatForGL is null.
|
Assignee | |
Comment 1•12 years ago
|
||
Here's a patch that handles the null case for render buffers and textures. Try server run: https://tbpl.mozilla.org/?tree=Try&rev=09132969a207
Attachment #637303 -
Flags: review?(bjacob)
|
||
Updated•12 years ago
|
Attachment #637303 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/74e381773948
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/74e381773948
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
|
|
Assignee | |
Comment 4•12 years ago
|
||
Opening the test case and about:memory in today's Nightly does not cause a crash now.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•