Closed
Bug 769304
Opened 12 years ago
Closed 12 years ago
Add accessibility platform status to about:support
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: hub, Assigned: hub)
References
Details
Attachments
(1 file, 1 obsolete file)
2.83 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
Followup on bug 759158 and bug 761589. We should add the status of the "platform disabled" in about:support
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → hub
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #637676 -
Flags: review?(gavin.sharp)
Attachment #637676 -
Flags: review?(dbolter)
Comment 2•12 years ago
|
||
Comment on attachment 637676 [details] [diff] [review] Add accessibility platform status to about:support. r= Review of attachment 637676 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comments addressed. If my comments seem wrong please ping me. ::: toolkit/content/aboutSupport.js @@ +422,5 @@ > + forceDisabled = getPrefValue("accessibility.force_disabled").value; > + > + document.getElementById("a11y-platform-force-disabled").textContent > + = (forceDisabled == -1) ? "forced enabled" : > + ((forceDisabled == 1) ? "forced disabled" : "enabled"); What do you think about this: In the dtd, aboutSupport.a11yForceDisabled = "Prevent Accessibility" And then we could keep the numeric values? (Or maybe go with "never" for -1) Gavin what do you think? ::: toolkit/content/aboutSupport.xhtml @@ +258,5 @@ > + <th class="column"> > + &aboutSupport.a11yForceDisabled; > + </th> > + > + <td id="a11y-platform-force-disabled"> Maybe "a11y-force-disabled" is simpler as it matches the pref (?) - If you have a specific reason to include "platform" that's fine.
Attachment #637676 -
Flags: review?(dbolter) → review+
Comment 3•12 years ago
|
||
Comment on attachment 637676 [details] [diff] [review] Add accessibility platform status to about:support. r= accessibility.force_disabled already shows up in the "modified preferences" section, FWIW, but I guess you want to also add it here for easy reference? That's fine, I guess. As David suggests, I would stick with just printing the pref value (and maybe use "Forced State" as the title, since that's what the pref seems to actually be about?)
Attachment #637676 -
Flags: review?(gavin.sharp) → feedback+
Updated•12 years ago
|
Attachment #637676 -
Flags: feedback?(marco.zehe)
Comment 4•12 years ago
|
||
Comment on attachment 637676 [details] [diff] [review] Add accessibility platform status to about:support. r= I'd go with Gavin's suggestion. After all this tells if accessibility is always, never, or conditionally instanciated.
Attachment #637676 -
Flags: feedback?(marco.zehe) → feedback+
Comment 5•12 years ago
|
||
Sounds good.
Comment 6•12 years ago
|
||
Wait. Forced State = 1 seems like a lie then (since it really means forced disabled).
Comment 7•12 years ago
|
||
Well that's your own fault for choosing weird -1/0/1 values :) I don't know what would make it clearer, maybe "Forced State Preference Value"?
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #7) > Well that's your own fault for choosing weird -1/0/1 values :) I don't know > what would make it clearer, maybe "Forced State Preference Value"? I think "Prevent Accessibility" seems to be the easier to understand. Even though this is "diagnostic" information.
Assignee | ||
Comment 9•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #637676 -
Attachment is obsolete: true
Assignee | ||
Comment 10•12 years ago
|
||
Comment on attachment 637949 [details] [diff] [review] Add accessibility platform status to about:support. what do you thing of the new wording?
Attachment #637949 -
Flags: review?(dbolter)
Comment 11•12 years ago
|
||
Comment on attachment 637949 [details] [diff] [review] Add accessibility platform status to about:support. Fine with me.
Attachment #637949 -
Flags: review?(dbolter) → review+
Assignee | ||
Comment 12•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d444d01ef71c
Comment 13•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d444d01ef71c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•