769355 - Implement <input type=date> max attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Raphael Catolino (:raphc)]

Attachment: patch

This patch uses functions from the patch in bug 769370. As long as this one as not been r+ this one might change so a review might not be useful yet. Feedback would still be appreciated though.

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 645693 [details] [diff] [review]
patch

Review of attachment 645693 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +1267,5 @@
>    nsAutoString maxStr;
>    GetAttr(kNameSpaceID_None, nsGkAtoms::max, maxStr);
>  
> +  double max;
> +  bool result = GetDoubleFromString(maxStr, max);

I know understand why you created that method in a previous patch. It will be indeed needed here. Though, I don't quite like the name.
What about: ConvertStringToNumber(), so it will match the specification's naming?

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 645693 [details] [diff] [review]
patch

Review of attachment 645693 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +4577,5 @@
> +        double max = GetMaxAsDouble();
> +        MOZ_ASSERT(!MOZ_DOUBLE_IS_NaN(max));
> +
> +        maxStr.AppendFloat(max);
> +      } else {

else if (mType == NS_FORM_INPUT_DATE)
and:
} else {
MOZ_NOTREACHED();
}

Comment 4

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 650131 [details] [diff] [review]
patch

Review of attachment 650131 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +1275,5 @@
>    GetAttr(kNameSpaceID_None, nsGkAtoms::max, maxStr);
>  
> +  double max;
> +  bool result = ConvertStringToNumber(maxStr, max);
> +  return result ? max : MOZ_DOUBLE_NaN();

You can do:
return ConvertStringToNumber(maxStr, max) ? max : MOZ_DOUBLE_NaN();

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 650131 [details] [diff] [review]
patch

Review of attachment 650131 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +4603,5 @@
> +        maxStr.AppendFloat(max);
> +      } else if (mType == NS_FORM_INPUT_DATE) {
> +        GetAttr(kNameSpaceID_None, nsGkAtoms::max, maxStr);
> +      } else {
> +        NS_NOTREACHED("Invalid input type");

nit: please change that to "Unexpected input type".

Comment 7

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 8

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 9

[Raphael Catolino (:raphc)]

Attachment: patch

Updated patch.

Comment 10

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/739b8e307069

Comment 11

[Florian Scholz (Open Web Docs)]

See bug 866440 for documentation.