769377 - Build warning: jswrapper.cpp:129:18: warning: base ‘js::IndirectProxyHandler’ will be initialized after [...] base ‘js::Wrapper’ [-Wreorder]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

../../../mozilla/js/src/jswrapper.cpp: In constructor ‘js::AbstractWrapper::AbstractWrapper(unsigned int)’:
../../../mozilla/js/src/jswrapper.cpp:129:18: warning: base ‘js::IndirectProxyHandler’ will be initialized after [-Wreorder]
../../../mozilla/js/src/jswrapper.cpp:129:18: warning:   base ‘js::Wrapper’ [-Wreorder]
../../../mozilla/js/src/jswrapper.cpp:127:1: warning:   when initialized here [-Wreorder]

Basically: the two parent-class constructors invoked by the AbstractWrapper constructor's init list are listed in the wrong order. (They're backwards from how they're listed in the class definition.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

This fixes it.

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 637608 [details] [diff] [review]
fix

Nevermind -- Eddy's going to be touching this code further in bug 703537, so I believe he's going to fix this over there.

Comment 3

[Daniel Holbert [:dholbert]]

(We can just resolve this as WFM when the next patch on bug 703537 lands)

Comment 4

[Daniel Holbert [:dholbert]]

Resolving as FIXED by this changeset (from bug 703537):
  http://hg.mozilla.org/mozilla-central/rev/53e0f8e066f4#l1.12