769495 - about:newaddon should scale better with multiple add-ons

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

At the moment, if there are multiple addons detected as requiring about:newaddon to enable them, we open a tab for every add-on. This can especially be a lot of addons if the DB becomes corrupt. Unfortunately, so many tabs can feel very overwhelming.

I wonder if we can make that scale better, by displaying multiple addons in one about:newaddon instance.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Sachin, let's ignore the dependency on bug 834385 and create a prototype that doesn't include vendor comments for now. We need to figure out what to do with bug 834385, and that might take some time.

Comment 3

[Sachin Hosmani [:sachin]]

Attachment: New opt-in screen screenshot

Yes, I have been working on creating a prototype.
I've been able accomplish the functional aspects of the new opt-in screen.
This is what it looks like. It's basically a richlistbox of a fixed size that holds all the add-on items. The about:newaddon URL format has been modified to support multiple add-ons.
Please give feedback.

Comment 4

[Sachin Hosmani [:sachin]]

Attachment: patch

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

I would only move the "Check the add-ons..." text so that it is right below the listbox and it aligns with its left edge. If that text is longer (like, in another language), it should wrap at the right edge of the listbox. So, pretty much like how the text above the listbox looks like.

Another nit: the warning icon looks stretched vertically.

Other than that, the listbox looks like the right solution.

Comment 6

[Sachin Hosmani [:sachin]]

Attachment: screen (2)

I've made the changes that Jorge mentioned.
And yes, the description "Check the add-ons..." gets wrapped if it is longer in another language.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

Comment on attachment 779132 [details]
screen (2)

Looks good to me! Can you attach the latest version of the patch and request UX review?

Comment 8

[Sachin Hosmani [:sachin]]

Attachment: patch (2)

Comment 9

[Sachin Hosmani [:sachin]]

Attachment: patch (3)

Fixed a few small mistakes in patch(2).

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 779132 [details]
screen (2)

Redirecting review since it was dead in the water when assigned to ux-review@.

Comment 12

[Andrew Swan [:aswan]]

about:newaddon has been replaced by a new sideloading flow.