769514 - Kill the Mac bitmap fallback code in nsSVGOuterSVGFrame

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Roc tells me that with Layers we shouldn't be drawing direct to the window, so it seems like the bitmap fallback code in nsSVGOuterSVGFrame is useless and should just be removed.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Err, ignore the nsSVGGlyphFrame.cpp change.

Comment 3

[Jonathan Watt [:jwatt]]

Just for record keeping, this was previously tried in bug 411334.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 637750 [details] [diff] [review]
patch

Review of attachment 637750 [details] [diff] [review]:
-----------------------------------------------------------------

R+ with that

::: layout/svg/base/src/nsSVGOuterSVGFrame.cpp
@@ +492,5 @@
>  #endif
>  
>    aContext->PushState();
> +  frame->Paint(aBuilder, aContext, mVisibleRect, ToReferenceFrame());
> +  aContext->PopState();

we shouldn't need this PushState/PopState pair. Try removing it.

Comment 5

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/caaf9085c7d8

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/caaf9085c7d8