769533 - get rid of AppendwithConversion

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Makoto Kato [:m_kato]]

Attachment: replace AppendWithConversion with others

Comment 1

[Makoto Kato [:m_kato]]

Attachment: get rid of AppendWithConversion

Comment 2

[Justin Lebar (not reading bugmail)]

I can review this early next week if you like, Makoto.  My review load is probably lower than dbaron's.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That's fine.  I think the main interesting thing to investigate is whether the removal of the null-check is safe for all of the char*/PRUnichar* callers.

Comment 4

[Justin Lebar (not reading bugmail)]

Comment on attachment 637775 [details] [diff] [review]
replace AppendWithConversion with others

># HG changeset patch
># Parent 2791940fb1ff454482ed91a76c9865c14b7b924e
>
>Part 1: replace AppendWithConversion with others
>
>dbaron: I think the main interesting thing to investigate is whether the
>removal of the null-check is safe for all of the char*/PRUnichar* callers.

I'm not sure what you mean -- AppendASCIItoUTF16 and LossyAppendUTF16toASCII both do null-checks on the pointers, so we should be good, right?

r=me pending dbaron's confirming that I'm not missing something here.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Justin Lebar [:jlebar] from comment #4)
> I'm not sure what you mean -- AppendASCIItoUTF16 and LossyAppendUTF16toASCII
> both do null-checks on the pointers, so we should be good, right?

Oh, right.

Comment 6

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c3fc27e9746
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a96f6193e75

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/3c3fc27e9746
https://hg.mozilla.org/mozilla-central/rev/5a96f6193e75