769623 - autobinscope.py uses win line endings and doesn't dump failure logs

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Jim Mathies [:jimm]]

Attachment: nix win line endings in autobinscope.py

no code changes, just stripping out the wrong line endings.

Comment 2

[Jim Mathies [:jimm]]

Attachment: dump binscope log on failure

When this fails we should dump the binscope log into the tinderbox logs for easy debugging.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 637861 [details] [diff] [review]
dump binscope log on failure

Review of attachment 637861 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/win32/autobinscope.py
@@ +71,4 @@
>    print "TEST-UNEXPECTED-FAIL | autobinscope.py | %s is missing a needed Windows protection, such as /GS or ASLR" % binary_path
> +  logfile = open(log_file_path, "r")
> +  for line in logfile:
> +    print(line),

Extraneous comma?

Comment 4

[Jim Mathies [:jimm]]

> > +    print(line),
> 
> Extraneous comma?

nope, this avoids double spacing each line. I guess print adds it's own return character, and the log has those as well.

Comment 5

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a31f6253167
https://hg.mozilla.org/integration/mozilla-inbound/rev/05a436f462e7

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a31f6253167
https://hg.mozilla.org/mozilla-central/rev/05a436f462e7