769709 - context menu problem with iframes

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Builder example: https://builder.addons.mozilla.org/addon/1061187/latest/

To reproduce:

1. load this page: http://www.historyworld.net/textonly/printpg.asp?type=histories&pid=hav&nid=aa61&pcount=5

2. enable the add-on. 
3. select text on the main historyworld page ( it is actually a frame ), right click. You'll see the 'Blah Blah Blah' item in the menu.
4. hit refresh on the historyworld page, then right-click. The context menu item is gone.

Reported by @peced:

https://twitter.com/peced/status/218515992698044417

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

It shows up again if you right-click in the page, then go into the "This frame" submenu and reload the frame.

Comment 2

[n8chz]

> Reported by @peced:
> 
> https://twitter.com/peced/status/218515992698044417

First reported (and first caught) by antelope:

https://addons.mozilla.org/en-US/firefox/addon/prostetnic/reviews/user:6276603

Also fails on Ubuntu 11.10 w. Linux 3.2.7 (my setup).  Don't know what antelope is using.

Best guess is that selectionContext() is not firing.

Comment 3

[n8chz]

> Also fails on Ubuntu 11.10 w. Linux 3.2.7 (my setup).  

& Firefox 13.0.1

> Best guess is that selectionContext() is not firing.

My best guess, that is :)

Comment 4

[n8chz]

(In reply to Wes Kocher (:KWierso) from comment #1)
> It shows up again if you right-click in the page, then go into the "This
> frame" submenu and reload the frame.

Yeah, but that's cheating.

Comment 5

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Cool, thanks for adding the additional info. We'll triage this bug this week but IMO it's pretty obvious breakage.

Wes, I feel like we should have a 'context-menu-sucks' whiteboard or something.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Jeff Griffiths from comment #5)
> Wes, I feel like we should have a 'context-menu-sucks' whiteboard or
> something.

Sure.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Can we test this with the fix for the Gmail fix landed?

Comment 8

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

It looks like it maybe caused by the same iframe hide / show reasons as bug 665386.

Comment 9

[Dave Townsend [:mossop]]

So likely not the same fix, Matteo can you take a look at this please?

Comment 10

[Matteo Ferretti [:zer0] [:matteo]]

I think the bug 664386 fixed that, I'm not able to reproduce this behavior.

Jeff, could you confirm that is gone?

Comment 11

[Matteo Ferretti [:zer0] [:matteo]]

I mean, bug 665386 ;)

Comment 12

[Matteo Ferretti [:zer0] [:matteo]]

I don't see any interaction on code side between context-menu module and selection module (I thought that `context-menu` uses `selection` for the `SelectionContext` at least, but it's doing that manually), so likely the bug 665386 is not related. However, I'm not able to reproduce the behavior described by this bug on Firefox 14.0.1. Jeff, could you confirm as well? Otherwise we'll try to understand where is the difference (maybe I'm doing something wrong in order to reproduce it).

Comment 13

[Dave Townsend [:mossop]]

I can reproduce this with https://addons.mozilla.org/en-US/firefox/addon/prostetnic/, having difficulty getting a simplified testcase though

Comment 14

[Matteo Ferretti [:zer0] [:matteo]]

I will try this add-on and see if I can reproduce the bug. If I can, I will debug the add-on to find the reason and/or create a simplest testcase.

Mossop, this issue is still present in your new context-menu module?

Comment 15

[Dave Townsend [:mossop]]

(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #14)
> I will try this add-on and see if I can reproduce the bug. If I can, I will
> debug the add-on to find the reason and/or create a simplest testcase.
> 
> Mossop, this issue is still present in your new context-menu module?

Until we have add-on source to build against I can't really tell. I attempted to hand-repack the XPI with the latest SDK and couldn't reproduce it there so it's possible it's even already fixed in master, but it's also possible I was just doing it wrong.

Comment 16

[Dave Townsend [:mossop]]

I did a little more digging and I can now reproduce this with a very simple testcase, but only in my normal Firefox profile. In a clean profile the problem vanishes so there is something profile specific going on here which might explain why some people see it and some don't

Comment 17

[Dave Townsend [:mossop]]

And the good news is that it does go away with my context-menu rewrite, the challenge is going to be figuring out how to test it since it's profile specific

Comment 18

[Dave Townsend [:mossop]]

Fixed by bug 788324