Closed
Bug 769722
Opened 12 years ago
Closed 12 years ago
Unnecessary parens in nsGlobalWindow::GetFuzzTimeMS
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: khuey, Assigned: bsurender)
References
Details
There's no need for parentheses around randNum at http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.466. In fact, that if block could go away entirely if it weren't for the randNum == MAX_IDLE_FUZZ_TIME_MS case.
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #0) > There's no need for parentheses around randNum at > http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.466. > > In fact, that if block could go away entirely if it weren't for the randNum > == MAX_IDLE_FUZZ_TIME_MS case. yeah sorry about the parentheses. it was passed as a function argument before which deref'd to assign the value. after the clean up last night i forgot to remove the parentheses. block has gone. i just mod it regardless.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 2•12 years ago
|
||
Did you check this in?
Comment 3•12 years ago
|
||
It's not fixed in the inbound tree I just pulled... If this is fixed in some other patch, the right thing to do here is mark this bug as depends-on that bug, and mark this as fixed only once that bug is fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 4•12 years ago
|
||
> only once that bug is fixed.
And by that, I mean, only once that bug is checked in.
(In reply to Justin Lebar [:jlebar] from comment #4) > > only once that bug is fixed. > > And by that, I mean, only once that bug is checked in. Got it. Thanks.
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c42f5fdc769
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•