769879 - bedrock's vendor lib is not at the right hash

Status: RESOLVED WORKSFORME

(www.mozilla.org :: Bedrock, defect)

Description

[Nigel Babu [:nigelb]]

I've been helping a contributor setup bedrock on his machine, he just ran into this error.

    priya@Ideapad-Z460:/media/DATA/users/kesavan/misc/git/bedrock$ ./manage.py update_product_details
    /usr/local/lib/python2.7/dist-packages/funfactory/manage.py:47: UserWarning: You're using an old-style Playdoh layout with a top level __init__.py and apps directories. This is error prone and fights the Zen of Python. See http://playdoh.readthedocs.org/en/latest/getting-started/upgrading.html
      warnings.warn("You're using an old-style Playdoh layout with a top "
    Traceback (most recent call last):
      File "./manage.py", line 21, in <module>
        manage.setup_environ(__file__)
      File "/usr/local/lib/python2.7/dist-packages/funfactory/manage.py", line 84, in setup_environ
        import settings
      File "/media/DATA/users/kesavan/misc/git/bedrock/settings/__init__.py", line 1, in <module>
        from .base import *
      File "/media/DATA/users/kesavan/misc/git/bedrock/settings/base.py", line 7, in <module>
        from funfactory.settings_base import *
      File "/usr/local/lib/python2.7/dist-packages/funfactory/settings_base.py", line 281, in <module>
        from django_sha2 import get_password_hashers
    ImportError: cannot import name get_password_hashers 

I looked at the vendor for bedrock and it doesn't seem to be updated to the right point in playdoh where the django-sha2 has the get_password_hashers function.

Comment 1

[Casey Becking]

This issue is blocking me from contributing as well.

Comment 2

[u465284]

I've run in a similar issue. I need the latest version of playdoh-lib, so I do:

$ cd vendor
$ git pull origin master

After that, I get this status:

$ git status

#    modified:   src/bleach (new commits)
#    modified:   src/commonware (new commits)
#    modified:   src/django-arecibo (new commits)
#    modified:   src/django-sha2 (new commits)
#    modified:   src/funfactory (new commits)
#    modified:   src/jingo (new commits)
#    modified:   src/jingo-minify (new commits)
#    modified:   src/tower (new commits)

At this point everything works, but if I update submodules to get vendor back to unmodified state:

$ git submodule update

I get this error:

Traceback (most recent call last):

  File "/Users/giuseppe/Projects/bedrock/vendor-local/src/django/django/core/servers/basehttp.py", line 283, in run
    self.result = application(self.environ, self.start_response)

  File "/Users/giuseppe/Projects/bedrock/vendor-local/src/django/django/contrib/staticfiles/handlers.py", line 68, in __call__
    return self.application(environ, start_response)

  File "/Users/giuseppe/Projects/bedrock/vendor-local/src/django/django/core/handlers/wsgi.py", line 250, in __call__
    self.load_middleware()

  File "/Users/giuseppe/Projects/bedrock/vendor-local/src/django/django/core/handlers/base.py", line 47, in load_middleware
    raise exceptions.ImproperlyConfigured('Error importing middleware %s: "%s"' % (mw_module, e))

ImproperlyConfigured: Error importing middleware funfactory.middleware: "cannot import name staticfiles_storage"

which also seems related to submodule versions.

Comment 3

[Dan Poirier [:dpoirier]]

I've been working on bedrock for a while now and have not run into this. I think it's been fixed at some point.