Closed
Bug 769881
Opened 12 years ago
Closed 12 years ago
copyStringToClipboard Optional parameters should go at the end, also this will make it backward compatible for version bumped extensions.
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: philip.chee, Assigned: ehsan.akhgari)
References
Details
(Keywords: addon-compat)
Attachments
(1 file)
|
6.39 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
From 722872 Comment 26: > (In reply to Philip Chee from comment #21) >> > - void copyStringToClipboard(in AString aString, in long aClipboardID); >> > + void copyStringToClipboard(in AString aString, [optional] in nsIDOMDocument aDoc, in long aClipboardID); >> >> Won't it be better to put the |[optional] in nsIDOMDocument aDoc| at the end >> to make this method backward compatible for extensions that need to work in >> more than one version of Firefox/Thunderbird/etc? > > Please file a bug on that and assign it to me. Thanks! Also from Comment 23: > Are you even allowed a non-trailing optional parameter?
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #638201 -
Flags: review?(roc)
Attachment #638201 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/108984fa0a89
Target Milestone: --- → mozilla16
|
||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/108984fa0a89
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•