769908 - Switch DIR_INSTALL to INSTALL

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rain [:rain1] (inactive)]

DIR_INSTALL is going to be obsolete once bug 757252 is fixed. We should get rid of it.

This should be simple enough to do with a find and replace. We should fix this in both mozilla-central and comm-central.

Comment 1

[Sean DuBois]

(In reply to Siddharth Agarwal [:sid0] from comment #0)
> DIR_INSTALL is going to be obsolete once bug 757252 is fixed. We should get
> rid of it.
> 
> This should be simple enough to do with a find and replace. We should fix
> this in both mozilla-central and comm-central.

Siddharth I am new to Mozilla, and came here through the bugs with mentors program. Is this bug still a good one to help and close? I am just gonna grep around and find the DIR_INSTALL string and change it where need be.

After thats all done just attach a unified patch from hg?

Comment 2

[Rain [:rain1] (inactive)]

That would be good, but what would be even better would be if you converted single-line commands to install_cmd. See bug 680636.

Comment 3

[Sean DuBois]

Attachment: Fix for bug 769908

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 640672 [details] [diff] [review]
Fix for bug 769908

Review of attachment 640672 [details] [diff] [review]:
-----------------------------------------------------------------

This looks just about good, but you missed a spot:
http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/ipc/Makefile.in#48

Comment 5

[(not currently active) Ted Mielczarek]

Thanks for the patch! If you fix that one issue we should be able to get it landed.

Comment 6

[Sean DuBois]

Attachment: 2nd Patch

Ted here is the new patch with the line I missed. Thanks!

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 644430 [details] [diff] [review]
2nd Patch

Review of attachment 644430 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/687711cf6f30

Thanks for the patch, Sean! One request - to make life easier for those checking in on your behalf, please follow the directions at the link below for any future patches you submit to make sure that all the necessary commit information is present. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/687711cf6f30

Comment 10

[Rain [:rain1] (inactive)]

Pushed a bustage fix from trailing whitespace after a backslash: http://hg.mozilla.org/mozilla-central/rev/cb0b3e605cf1