770116 - Test failure 'The pane did not load in time: paneTabs ' when switching panes in preferences window

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the fix on bug 757340 we have introduced a new regression which is intermittent. In some cases tests fail to switch to the target pane due to a timeout in our test. We probably should increase it. How long was the waiting time before? Remus, can you please take that?

http://mozmill-ci.blargon7.com/#/l10n/report/23e194f1171aa4baf774928b2624c069

Comment 1

[Remus Pop (:RemusPop)]

We were using the default timeout (5s). So the waiting time is the same.

Comment 2

[Remus Pop (:RemusPop)]

The problem is that with the no animation pref of the pref pane, nodeToProcess.style.opacity == 1 will always be false.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Why is that a problem? We do not rely on this CSS style in our test. Why should it then affect the waitFor() call?

Comment 4

[Remus Pop (:RemusPop)]

That line is the one that makes the waitFor pass on Mac when we the animation is on.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We do not have the animation enabled! We pref it off before changing the panes. What we are waiting for is the target pane to be selected. There is no transition related code in here:

http://hg.mozilla.org/qa/mozmill-tests/file/32421e34b8d8/lib/prefs.js#l90

Please try if you can reproduce locally.

Comment 6

[Remus Pop (:RemusPop)]

I was talking about this waitFor:
http://hg.mozilla.org/qa/mozmill-tests/file/32421e34b8d8/lib/dom-utils.js#l345

Yes, I can reproduce it locally.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh wow. Yes, those to lines have to be removed than.

Comment 8

[Remus Pop (:RemusPop)]

What 2 lines? Please check the whole condtion.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Remus Pop (:RemusPop) from comment #8)
> What 2 lines? Please check the whole condtion.

Those two lines you was talking about in comment 2. If you have problems please lets discuss this on IRC. This process here slows us down.

Comment 10

[Remus Pop (:RemusPop)]

Attachment: patch v1 (aurora)

The style is no longer affected if we don't have animation (which is disabled in the setter of paneId BTW) so I removed it.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 638686 [details] [diff] [review]
patch v1 (aurora)

That works. Thanks for the patch!

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given that we do not have any tests running on default only which exercise this code path, I pushed it to default and aurora:

http://hg.mozilla.org/qa/mozmill-tests/rev/a3b6cf6264c5 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/40b3a0afa3ac (aurora)

If that works I will land on the other branches soon.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Works fine for latest fi locale:
http://mozmill-ci.blargon7.com/#/l10n/report/4c461f9adf1253771fc6455667068493

Pushed to other branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/29b29d43c658 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/9376a5d0b545 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/27b549e8598c (esr10)